Feedback on new crypto primitives and API #20
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
help wanted
Extra attention is needed
question
Further information is requested
Comments
Foxboron
added
documentation
|
Sounds good, we will adapt to the new APIs as needed. Thanks for keeping us updated! |
|
Tested the new API for my use-case. The new authenticode parsing API looks nice and seems to produce identical results. |
ln5
pushed a commit
to system-transparency/stmgr
that referenced
this issue
Apr 4, 2024
Signing is attempted if and only if both -signkey and -signcert as passed. go-uefi has a new API for authenticode signing, but it is not used as it does not seem to be finalized. See: Foxboron/go-uefi#20
|
Old code has been removed in famour of the new stuff. Closing this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Yo,
I'm poking a bunch of people that is currently using this library to help provide feedback before I remove the old code. I assume people are relying on this code in different manners and It's hard for me to keep track.
x/crypto/cryptobytewhich is a lot easier to understand and deal with then the old struct based ASN.1 code.authenticodeappends signatures and rewrites the binary with severalSectionReaderandio.MultiReader. I suspect this is the less clever part of the new code instead of reading the file as a byte slice and doing surgery on the file that way.efivarfsis a new abstraction to deal withefivarfs.efivarfsfor testing purposes.New code example to sign a binary in the README.md.
Feel free to come with opinions and requests for the rewritten code :)
@zaolin @smoser @werwurm @malt3 @flanfly @robertfairhead @smira @edgrz
The text was updated successfully, but these errors were encountered: