Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no notification permission issue #221

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix no notification permission issue #221

wants to merge 4 commits into from

Conversation

austinoneil
Copy link

@austinoneil austinoneil commented Apr 28, 2024 •
edited

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • Fix issue when user could not add an event/task when notification permission was not granted.
  • Refactored some logic, extracting reused code into a reusable function.

Before/After Screenshots/Screen Record

  • Before:
  • After:

Fixes the following issue(s)

Acknowledgement

@Aga-C
Copy link
Member

Aga-C commented Apr 29, 2024 •
edited

It should ask for the permission at least on the first app startup. Most people won't think about turning manually the permission. Remember that this app isn't done only for technically advanced users.

@austinoneil
Copy link
Author

@Aga-C Good idea. I added a check in the latest commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot take off alarm without adding notification permission
2 participants
@austinoneil @Aga-C