Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: postinstall script forces package to become unplugged with yarn pnp #19577

Open
3 tasks done
mcenkar opened this issue Feb 24, 2023 · 1 comment
Open
3 tasks done
Labels

Comments

@mcenkar
Copy link

mcenkar commented Feb 24, 2023

Is your feature request related to a problem?

No response

Feature description

Hi,

because of postinstall script when using yarn with pnp mode it unnecessarily unplugs package extracting all the icons from an archive. For most packages that is not a big overhead, but with FA we have thousands of files per package that are extracted.

Since this postinstall script only prints licence and copyright can you consider removing it from all packages? There is possible workaround that helps but IMHO worth to consider fixing underlying issue:

  "dependenciesMeta": {
    "@fortawesome/fontawesome-common-types": {
      "built": false
    },
    "@fortawesome/free-brands-svg-icons": {
      "built": false
    },
    ...
  }

Alternatives

No response

Additional context

No response

Feature request checklist

  • The title starts with "Feature request: " and is followed by the requested feature description
  • This is a single feature
  • I have searched for existing issues and to the best of my knowledge this is not a duplicate
mcenkar added a commit to mcenkar/Font-Awesome that referenced this issue Feb 24, 2023
@mcenkar
Copy link
Author

mcenkar commented Feb 24, 2023

Just noticed there is already existing issue #18803 with much better description.

However it's been open for a while and not fixed yet so I thought I'll open PR #19578

Please let me know if I should rebase it against master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant