Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Font display property missing when using Font Awesome Kit #19376

Closed
1 of 2 tasks
comi91 opened this issue Oct 12, 2022 · 1 comment
Closed
1 of 2 tasks

Bug: Font display property missing when using Font Awesome Kit #19376

comi91 opened this issue Oct 12, 2022 · 1 comment
Labels
bug needs-triage This bug needs to be confirmed

Comments

@comi91
Copy link

comi91 commented Oct 12, 2022

Bug description

Lighthouse reports: Ensure text remains visible during webfont load. This can be solved with font-display:swap for @font-face. See https://web.dev/font-display/?utm_source=lighthouse&utm_medium=devtools
When using a kit with web font, we can not set this property.

Reproducible test case

No response

Screenshots

No response

Font Awesome version

latest 6.x version

Serving

Kit

Implementation

Other (as specified in the bug description)

Browser and Operating System

Chrome 106 on MacOs

Web bug report checklist

  • I have included a test case because my odds go way up that the team can fix this when I do
  • I have searched for existing issues and to the best of my knowledge this is not a duplicate
@comi91 comi91 added bug needs-triage This bug needs to be confirmed labels Oct 12, 2022
@tagliala
Copy link
Member

Hi!

This is a false positive and we cannot fix it on our side. Having font-display:swap is wrong with icon fonts

In the past I think someone on lighthouse side added FontAwesome to an allowlist of fonts.

Ref: #16077

Closing here, but feel free to comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs-triage This bug needs to be confirmed
Projects
None yet
Development

No branches or pull requests

2 participants