New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FontAwesome Kit ruins Lighthouse site performance results #16146
Comments
Related to #16077 in that they are both somewhat Lighthouse related, although this one is more critical from a performance perspective.. |
@tagliala Could you please tag this appropriately? ❤️ |
Hi @alystair sorry for the late reply Could you please provide a reproducible test case that is related to Font Awesome Kit rather than fontawesome.com documentation? Auditing here is not that terrible: https://tagliala.github.io/fa15167-kit |
Hi, i have the same issue with random big response time. This problem is in your example too @tagliala. |
at 4x slowdown, the fact that my entire web framework inits in 80-140ms best/worst scripting time compared to 210-420ms of the barebone demo you provided means something funky is going on. Looking at FA's network graph alone I'd guesss instead of parsing the DOM first and collecting all outstanding icons for a 'batch' fetch, it starts fetching whilst parsing? Using raw SVGs for our mission critical work for now... don't have time to drill down into the script/code. |
@toomsbzh Let's ask @robmadole if he is aware of random slow response time of individual svg files
Thanks for the hint. That demo is not optimized for performance, I'm just synchronously loading a kit in the head tag for other purposes, but I can see what you are saying and it looks it depends on how the Pro kit individually fetches the icons found @robmadole could you please check if there is room for improvement here?
I think that it is the best choice for your use case, and this should be one of the reason why we are providing individual svgs. I think that loading the FA SVG framework, via cdn, kit or optimized pro kit, will introduce an overhead that does not seem compatible with your performance constraints |
It's just overall concern for FA Kit overhead on mobile devices. There's probably room for optimization, which would allow for wider adoption :) |
Yes, we've had reports about this. Our CDN provider and a lot of other providers are experiencing issues during COVID-19. @toomsbzh if this is a persistent issue send us an email at hello@fontawesome.com so we can take a deeper look.
Our own site (fontawesome.com) is abysmal but our use case is pretty unique. Do you have a Lighthouse report for your own site?
That does sound funky. Do you have a test case we can take a look at?
Correct. This is intentional. We also use
We looked at mobile performance with Kits and didn't see anything problematic. If you have some evidence that we missed something we'd love to see some numbers. I'm inclined to close this issues unless there is something specific we need to work on. |
Describe the bug
FontAwesome Kit has a major impact on Lighthouse performance score. This probably represents real life performance implications on older mobile devices.
To Reproduce
Visit https://web.dev/measure/ or use Chrome's built-in Lighthouse in DevTools with default settings to test any site using a FontAwesome Kit /w SVG. Heck, running it on a simple page like https://fontawesome.com/icons/font-awesome-flag results in a performance score of... 4 (out of 100).
Expected behavior
FontAwesome JS should not block main thread in such an impactful manner.
Screenshots
https://fontawesome.com/icons/font-awesome-flag
Own site, larger impact
Version and implementation
Version: Latest (kit)
Browser and version: Chrome Version 79.0.3945.130 (Official Build) (64-bit)
Bug report checklist
The text was updated successfully, but these errors were encountered: