Undefined containerComponent results in TypeError

[jesper-stighem-pini]

Is there an existing issue for this?

• I have searched the existing issues

Mentioned here: #2748 (comment)

Code of Conduct

• I agree to follow this project's Code of Conduct

Victory version

37.0.1

Code Sandbox link

https://codesandbox.io/p/sandbox/victory-starter-forked-cyh3wf

Bug report

We have a custom container on a chart that we want to use in some views, but not all. Setting containerComponent to undefined however crashes the application (TypeError) as Victory tries to read containerComponent.props.

<VictoryChart containerComponent={condition ? <CustomContainer/> : undefined}>
  <VictoryLine />
</VictoryChart>

Expected behavior

We expected containerComponent={undefined} to behave as if no containerComponent was set.

We thought this:

<VictoryChart containerComponent={undefined}>
  <VictoryLine />
</VictoryChart>

Should work as this:

<VictoryChart>
  <VictoryLine />
</VictoryChart>

[madox2]

Same issue after upgrade from 36.6.11 to 36.9.2. I was able to workaround by spreading an object:

<VictoryChart {...(condition ? { containerComponent: <CustomContainer /> } : {})}>
  <VictoryLine />
</VictoryChart>

[carbonrobot]

Will be released in 37.0.2