Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 37 SyntaxError Unexpected number when importing #2839

Closed
2 tasks done
andy-root opened this issue Mar 22, 2024 · 3 comments
Closed
2 tasks done

Version 37 SyntaxError Unexpected number when importing #2839

andy-root opened this issue Mar 22, 2024 · 3 comments
Labels
Issue: Accepted The submitted issue has been confirmed by the Victory core team Type: Bug 🐛 Oh no! A bug or unintentional behavior

Comments

@andy-root
Copy link

andy-root commented Mar 22, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Code of Conduct

  • I agree to follow this project's Code of Conduct

Victory version

37

Code Sandbox link

https://codesandbox.io/p/sandbox/victory-starter-dj4f7t

Bug report

Importing version 37 results in an SyntaxError Unexpected number, I tried the default Code Sandbox link, I tried creating a new Sandbox link and manually importing Victory latest and 37.0.0, they are fail with the same error. If I change the victory version to 36.0.0 then importing succeeds.

Version 37
https://codesandbox.io/p/sandbox/victory-starter-dj4f7t

Version 36
https://codesandbox.io/p/sandbox/victory-version-36-rdsl3n

Steps to reproduce

  1. import { VictoryChart, VictoryLine } from "victory";
  2. set version to latest' to 37.0.0

Expected behavior

Expect importing latest victory to not fail from a SyntaxError

Actual behavior

importing latest victory fails from a SyntaxError

Environment

  • Device: Desktop
  • OS: Mac
  • Browser: Chrome
@andy-root andy-root added the Type: Bug 🐛 Oh no! A bug or unintentional behavior label Mar 22, 2024
@carbonrobot
Copy link
Contributor

Thanks for the report @andy-root, I am also seeing the same thing in Codesandbox. It appears to work in Stackblitz and Codepen. I also spun up a Next14 app, Astro, and Vite and they appear to be working. I'll look into the Codesandbox problem.

Is it impacting your application code? And if so, can you tell me more about your environment/project setup?

@carbonrobot carbonrobot added the Issue: Accepted The submitted issue has been confirmed by the Victory core team label Mar 22, 2024
@andy-root
Copy link
Author

andy-root commented Mar 22, 2024

No, I'm using version 36 in my project. It was affecting the creation of Codesandbox examples using the default latest version (37).

@carbonrobot
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Accepted The submitted issue has been confirmed by the Victory core team Type: Bug 🐛 Oh no! A bug or unintentional behavior
Projects
None yet
Development

No branches or pull requests

2 participants