-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
formatXLabel will pass an undefined label on Samsung devices #185
Comments
I have the same issue on a standard Pixel 3a (API 34) Android emulator. It occurs when I'm adding some domain padding, undefined value will be passed then to formatXLabel. |
Hey @a-arshad, thanks for sharing! I noticed that you're using I wonder if there may have been some changes introduced in between that may be causing the issues you're seeing. Could you try installing Also, @akmere can you confirm your environment as well? |
Hey and my X-axis provides undefined labels. |
If anyone here wants to provide some sample data and the chart/code they were using here, I can take a deeper look! |
Prerequisites
Describe Your Environment
What version of victory-native-xl are you using? (can be found by running
npm list --depth 0 victory-native
)victory-native@40.0.3
What version of React and React Native are you using?
react@18.2.0
react-native@0.72.8
What version of Reanimated and React Native Skia are you using?
react-native-reanimated@3.6.1
@shopify/react-native-skia@0.1.230
Are you using Expo or React Native CLI?
React Native CLI
What platform are you on? (e.g., iOS, Android)
Android
Describe the Problem
We found that on Samsung Galaxy devices with their font size turned to the max within their accessibility settings,
formatXLabel
withinCartesianAxis.tsx
will pass an undefined value as a label.Expected behavior: [What you expect to happen]
A valid label string will be passed into the label parameter of the formatter.
Actual behavior: [What actually happens]
An undefined label is passed into the label parameter of the formatter.
Additional Information
After our own investigations we see that the error happens around
line 144
ofCartesianAxis.tsx
Our undefined value comes from the last tick being out of bounds on
ix
. There seems to be an issue with the number of ticks becomes larger than the actual available x metric values. Possibly when accessibility settings are changed our ticks become out of sync with what our data actually represents.The text was updated successfully, but these errors were encountered: