Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

Type codebase with flow #86

Open
aweary opened this issue Dec 1, 2017 · 3 comments
Open

Type codebase with flow #86

aweary opened this issue Dec 1, 2017 · 3 comments
Assignees

Comments

@aweary
Copy link

aweary commented Dec 1, 2017

I have a feeling some types would make maintaining/refactoring freactal a lot easier. I'm looking at implementing #51 and it would be helpful if everything was well typed first.

cc @ryan-roemer

@aweary
Copy link
Author

aweary commented Dec 1, 2017

@divmain would you be OK with this?

@ryan-roemer
Copy link
Member

@divmain -- Any last objections to applying flow to freactal? We'd ideally like to get this going soon-ish unless you have objections.

@divmain
Copy link
Contributor

divmain commented Dec 14, 2017

While I'm a fan of static typing in general, I'm on the fence with this proposal. The freactal code-base is small enough where typing is ideally unnecessary. I think exposing types for library consumers would be fantastic, but I view that as fundamentally separate.

@aweary, which parts of the code-base lead you to feel types would ease maintenance?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants