Skip to content
This repository has been archived by the owner on Feb 25, 2023. It is now read-only.

"Photo not net extracted" in koujien dictionary #2271

Open
Triramama opened this issue Nov 13, 2022 · 7 comments
Open

"Photo not net extracted" in koujien dictionary #2271

Triramama opened this issue Nov 13, 2022 · 7 comments

Comments

@Triramama
Copy link

Triramama commented Nov 13, 2022

Hello, I have setup 7th edition of koujien dictionary (広辞苑 第七版) on yomichan but for some reason the images that are, apparently, supposed to be fetched from a certain online resource(no idea what it is) aren't displaying and i have "Photo not net extracted" instead:
image
What this error could be attributed to, do you think? i tried turning on Japanese vpn in case that certain resource is region restricted, but nope, no luck.

@Thermospore
Copy link
Contributor

Hello, I am the one who converted this dictionary!

Sorry, this was actually a typo; it was supposed to say "Photo not yet extracted." At the time, we hadn't figured out how to extract the image data yet, so that is just placeholder text.

We actually just figured out how to extract them though, and I have a working prototype!
image

I meant to get it ready for release a couple weeks ago, but I'm pretty swamped at the moment, so it might be a little bit :(

@Triramama
Copy link
Author

Hello, I am the one who converted this dictionary!

Sorry, this was actually a typo; it was supposed to say "Photo not yet extracted." At the time, we hadn't figured out how to extract the image data yet, so that is just placeholder text.

We actually just figured out how to extract them though, and I have a working prototype! image

I meant to get it ready for release a couple weeks ago, but I'm pretty swamped at the moment, so it might be a little bit :(

So is it gonna be implemented soon? This dictionary has a lot of useful stuff it seems
image

@Thermospore
Copy link
Contributor

Unfortunately I am pretty swamped until mid December, but here is a temporary link to the work-in-progress version in the screenshot

For practical purposes it's 99% functional, there are just some odds and ends I want to tidy up

I'll update this thread with the final version

@peldas
Copy link

peldas commented Jan 27, 2023

@Thermospore Is your latest commit the final version you mentioned or do you still have some final touches to put on it?

@Thermospore
Copy link
Contributor

@kelpso It's aaalmost there, I mainly need to resolve a vertical alignment issue (#2289), check through the gaiji map (Thermospore/koj72yomi#3 etc), then pack it up and update the changelog

Which shouldn't take too long, but it's my last semester at uni and I'm applying for grad school so I'm swamped with stuff going on right now. Might even take a couple weeks before I can wrap it up :(

It's nice to know people are interested in it, I'll move it up higher on my priority list! Here is a temp link to the latest test version; feel free to let me know if you spot any issues

@Triramama
Copy link
Author

@Thermospore can i have that test build of yours again i've reinstalled windows and lost the file you gave me. btw it worked pretty fine as far as i would care

@Thermospore
Copy link
Contributor

@Triramama sure, sorry for the delay getting it finished, glad it's working well! I haven't heard about #2289 for a while so I'll probably just work around it for now

this should be the same test version as before

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants