Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Resources Not Being Included #876

Open
1 of 6 tasks
foohyfooh opened this issue Mar 25, 2023 · 4 comments
Open
1 of 6 tasks

Language Resources Not Being Included #876

foohyfooh opened this issue Mar 25, 2023 · 4 comments

Comments

@foohyfooh
Copy link

IF YOU DON'T ANSWER THIS TEMPLATE - THE BOT WILL AUTOMATICALLY CLOSE YOUR ISSUE!

Please check all of the platforms you are having the issue on (if platform is not listed, it is not supported)

  • WPF
  • UWP
  • iOS
  • Android
  • .NET Standard
  • .NET Core

Component

What component is this issue occurring in?

Version of Library

  • net7.0-windows
  • Fody 6.6.4
  • Costura.Fody 5.7.0

Version of OS(s) listed above with issue

Windows 10

Steps to Reproduce

  1. Clone https://github.com/foohyfooh/PKHeXPluginPile
  2. Open in Visual Studio
  3. Open InsertionPlugin>PositionForm in the form designer
  4. On the Form object, Change Design>Language from (Default) to Spanish
  5. Change any of the labels text and save it
  6. Build the solution
  7. Download and extract PKHeX (23.02.27)a-es.zip
  8. Copy the bin\Release\net7.0-windows\InsertionPlugin.dll to the plugins folder where you extracted PKHeX
  9. Run PKHeX and click on Herramientas>Insertion Plugin and you will notice the text hasn't changed
  10. Close PKHeX
  11. Copy bin\Release\net7.0-windows\es\InsertionPlugin.resources.dll to the plugins folder
  12. Run PKHeX and click Herramientas>Insertion Plugin and you will notice that the text has changed

Expected Behavior

The resources dll shouldn't need to be copied and all the language files would be bundled in the InsertionPlugin.dll like what is done with the PackageReferences which will allows switching of languages with one dll.

Actual Behavior

The resources dll needs to be copied for the language to change.

@tom-englert
Copy link
Member

tom-englert commented Mar 25, 2023

Did you check if the resources are properly embedded, e.g. with ilspy?

If this is true, try calling CosturaUtility.Initialize() from your plugins entry point

@foohyfooh
Copy link
Author

foohyfooh commented Mar 25, 2023

This is what is ILSpy is showing me as the resources
ILSpy Resources

And with CosturaUtility.Initialize() I still get the same issue.

@JiuLing-zhang
Copy link

Any updates?

@GeertvanHorrik
Copy link
Member

It's on our to-do list, but probably similar as you, we have other responsibilities (and families and hobbies). There are several ways to speed things up:

  1. Investigate and provide a fix yourself
  2. Pay for support (because every hour we put into this is not billable to the people putting in the work (for free, for you))

If none of these are valid options, then you'll have to wait in line until we find time and energy to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants