After GM system on, GM2 system on does not re-activate bank select.

[nanitaro]

FluidSynth version

Execute fluidsynth --version and provide the output.

FluidSynth runtime version 2.3.5
Copyright (C) 2000-2024 Peter Hanappe and others.
Distributed under the LGPL license.
SoundFont(R) is a registered trademark of Creative Technology Ltd.

FluidSynth executable version 2.3.5
Sample type=double

Describe the bug

Provide a clear and concise description of the current situation, e.g. how the bug manifests.

1.GM system on. (Bank Select is disabled.)
2.The next time you perform a GS or XG reset, the bank select will remain inoperative.

Expected behavior

Provide a clear and concise description of what you expected to happen.

After performing a GS or XG reset, the bank select is to be re-activated.
There also seems to be a problem with the Voices not being initialized after executing a GS and XG reset.

Steps to reproduce

Please explain the steps required to duplicate the issue, esp. if you are able to provide a sample application. E.g. how to start fluidsynth, what shell commands to enter, what midi events to send, etc.

I have created a SMF file that reproduces the situation.
test.zip
SoundFont uses GeneralUser GS 1.471.

The SMF file is processed as follows.

1. Bank Select MSB 03.
2. Program Change 125.(Door is selected)
3. Door sound is played.
4. GM system on
5. Bank select MSB 03. (Ignored.)
6. Program change 125.(Telephone 1 is selected.)
7. Phone tone is sounded.
8. GS reset
9. Bank select MSB 03. (Ignored.)
10. Program change 125.(Telephone 1 is selected.)
11. Telephone tone is sounded.
12. XG system on
13. Bank select MSB 03.(Ignored.)
14. Program change 125.(Telephone 1 is selected.)
15. Telephone tone is sounded.

Bank select works with 9 and 13,
11 and 15 want the door tone to ring.

Additional context

If you are able to illustrate the bug with an example, please provide simple
source code below or as attached file. List any other information that is relevant to your issue, e.g. stack traces, related issues, build logs, suggestions on how to fix, links to related discussions at fluid-dev, etc.

insert code snippets, soundfonts or anything relevant here, or attach it as extra file(s) if it's too much

[mrbumpy409]

OMG, I was just running into this bug while testing for my upcoming GeneralUser GS update. I thought I was going crazy! One of the MIDI files I was testing must have been sending a GM reset command, and then after that, bank selection stopped working even after issuing a GS reset command. The only way to get bank select working again was to restart Qsynth.

[nanitaro]

Additional report.
As with GS and XG, the GM2 system on does not re-activate the bank select function.

[RoqueDeicide]

I've checked test.mid file in Sekaiju7.9. It appears, that you're sending GM System Enable message with device ID 0x7F, but the rest of your SysEx messages are being sent with device ID 0x10 (16 in decimal). Maybe you should try sending them with 0x7F instead.

In other words the GS message should look like this: F0 41 7F 42 12 40 00 7F 00 41 F7. This is the exact form that I use and it works for me.

And XG message: F0 43 7F 4C 00 00 7E 00 F7.

[nanitaro]

Thank you.
It seems to work as a hack.
However, GM2 system on still does not work.

Indeed, 0x7F (broadcast) was the standard for device IDs for GM and GM2 system on.
However, for GS reset and XG system-on device IDs, 0x10 was the standard.
As far as I know, for the XG system-on device ID, it is specified that it must be 0x1X (upper 4 bits fixed at 0001).
(This is described in the MU2000 manual.)

In many SMFs (Standard MIDI files), it was common to hack the GM system on and then do a GS reset (or XG system on).
It was done for compatibility reasons.
We would appreciate it if you could support GS reset and XG system on with the device ID set to 0x10 in order to play such SMFs correctly.

[RoqueDeicide]

GM2 style bank selection is currently not supported, probably because FluidSynth was designed for Soundfont 2 spec, which was made before GM2 was a thing.

As for device ID, you can set synth.device-id to 16 to enable GS and XG SysEx messages, or 127 to enable all SysEx messages.

Incidently, FluidSynth by choice doesn't follow XG standard when it comes to checking the device ID in the SysEx message: it compares the entire byte as opposed to its lower half. Apparently following XG standard to a T breaks a lot of MIDI files.

Here is a link to SysEx code section for more details:

fluidsynth/src/synth/fluid_synth.c

Line 1969 in cb8da1e

/**

[nanitaro]

FluidFeatures#sysex-messages
The documentation states that the GM2 system on works.
However, as it stands, after GM2 system on, bank select is disabled.
GM2 bank select is similar to XG, with MSB ignored and LSB specified.

For GS and XG, the desired behavior was achieved by setting the synth.device-id option to 16.
Thank you.
Perhaps it would be better to include in the documentation that this option be set to 16 when playing conventional SMF.
fluidsettings#synth.device-id

@mrbumpy409
I suspect this is a Qsynth issue where the synth.device-id option cannot be changed.
I will raise the issue in the Qsynth repository.
As for the GM2 system-on not working, this is a FluidSynth issue as described above.

[mrbumpy409]

I can confirm that changing the device ID in the GS reset SysEx to 7F allows CC0 bank change to work again. Thank you!