Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Lazy Data Provider #130

Open
brunoagretti opened this issue Feb 3, 2023 · 6 comments · May be fixed by #145
Open

Add support for Lazy Data Provider #130

brunoagretti opened this issue Feb 3, 2023 · 6 comments · May be fixed by #145
Assignees
@flang
Labels
enhancement
Projects
Flowing Code Addons (legacy)

Comments

@brunoagretti
Copy link
Member

It'd be great if we could use lazy data providers, just like in regular grids.
@javier-godoy javier-godoy added this to Inbox (needs triage) in Flowing Code Addons (legacy) via automation Feb 3, 2023
@javier-godoy
Copy link
Member

This requires a major refactoring (hence it's a good candidate for Version 3). The main issue is that the implementation assumes that the grid has a ListDataProvider. With a lazy data provider (in the "available" grid), the selected items would have to be filtered out, instead of removed.

@javier-godoy javier-godoy mentioned this issue Feb 3, 2023
Open
@javier-godoy
Copy link
Member

javier-godoy commented Feb 3, 2023 •
edited

I've just realized that filtering would also provide a nice solution for the scenario discussed in the linked issue (even with ListDataProvider). [comment retracted]

@javier-godoy javier-godoy moved this from Inbox (needs triage) to To Do in Flowing Code Addons (legacy) Feb 6, 2023
@flang flang self-assigned this Feb 6, 2023
@mlopezFC
Copy link
Member

One thing to take into account. Removing the items in the left grid might be impossible, so one idea would be to display them greyed out.

@flang flang moved this from To Do to In Progress in Flowing Code Addons (legacy) Feb 15, 2023
@flang
Copy link
Collaborator

flang commented Feb 16, 2023 •
edited

Does it make sense to support lazy providers on selected grid? IMO only available grid should support it.

@higgsja
Copy link

higgsja commented Feb 16, 2023 via email

@javier-godoy
Copy link
Member

Does it make sense to support lazy providers on selected grid? IMO only available grid should support it.

I agree. We can start by supporting lazy data providers on the available grid (which is already a big change), and discuss lazy providers on selected grid later. I'm not sure if there are use cases where supporting so many selected items is good UX.

flang added a commit that referenced this issue Feb 23, 2023
@flang
feat: Add lazy support to available items grid
3f16ce6 
Close #130
flang added a commit that referenced this issue Feb 23, 2023
@flang
feat: Add lazy support to available items grid
15ebc2c 
Close #130
flang added a commit that referenced this issue Feb 28, 2023
@flang
feat: Add lazy support to available items grid
38674a6 
Close #130
flang added a commit that referenced this issue Feb 28, 2023
@flang
feat: Add lazy support to available items grid
9f58d74 
Close #130
flang added a commit that referenced this issue Feb 28, 2023
@flang
feat: Add lazy support to available items grid
d442353 
Close #130
This was referenced Mar 3, 2023
Merged
Merged
@flang flang mentioned this issue Mar 3, 2023
Closed
flang added a commit that referenced this issue Mar 3, 2023
@flang
feat: add lazy support to available items grid
6ebe6a8 
Close #130
mlopezFC pushed a commit that referenced this issue Jul 6, 2023
@flang @mlopezFC
feat: add lazy support to available items grid
55d6c7a 
Close #130
flang added a commit that referenced this issue Jul 7, 2023
@flang
feat: Add lazy support to available items grid
bb6ac81 
Close #130
flang added a commit that referenced this issue Jul 24, 2023
@flang
feat: Add lazy support to available items grid
84774e4 
Close #130
@flang flang linked a pull request Jul 24, 2023 that will close this issue
Open
flang added a commit that referenced this issue Jul 24, 2023
@flang
feat: add lazy support to available items grid
199e613 
Close #130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flang flang

Labels
enhancement
Projects
Flowing Code Addons
Status: In Progress
Flowing Code Addons (legacy)
  
In Progress
Milestone
No milestone
5 participants
@flang @higgsja @javier-godoy @mlopezFC @brunoagretti