Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HeighByRows is off by one pixel #82

Open
javier-godoy opened this issue Jul 3, 2023 · 0 comments
Open

HeighByRows is off by one pixel #82

javier-godoy opened this issue Jul 3, 2023 · 0 comments
Labels
bug Something isn't working
Projects
Flowing Code Addons (legacy)

Comments

@javier-godoy
Copy link
Member

Integration test testOpenWithItemsDefaultSize (http://127.0.0.1:8080/it/height-by-rows/10) fails in Vaadin 23.3.15 / 24.1.1 because it expects the offsetSize to be 453px but it is computed as 452px.

The test is correct: the offset size must be the same as in testOpenWithItemsFullSize (http://127.0.0.1:8080/it/height-by-rows/10;fullsize), which computes the height as 453px.

image
@javier-godoy javier-godoy added the bug Something isn't working label Jul 3, 2023
@javier-godoy javier-godoy added this to Inbox (needs triage) in Flowing Code Addons (legacy) via automation Jul 3, 2023
@mlopezFC mlopezFC moved this from Inbox (needs triage) to Under consideration in Flowing Code Addons (legacy) Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Flowing Code Addons
Status: Under consideration
Flowing Code Addons (legacy)
  
Under consideration
Milestone
No milestone
Development

No branches or pull requests
1 participant
@javier-godoy