Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components inside of dense grid #58

Open
javier-godoy opened this issue Feb 3, 2023 · 1 comment
Open

Components inside of dense grid #58

javier-godoy opened this issue Feb 3, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@javier-godoy
Copy link
Member

javier-godoy commented Feb 3, 2023

A vaadin-button inside of a grid with dense theme forces the whole row to a min height of 36px (--lumo-size-m plus margin)
image

(compare with the same row sans buttons)
image

Maybe we should provide some (opt-in?) styles for these cases:

[theme~="fcGh-dense"] vaadin-button {
  margin: 0;
  --lumo-button-size: var(--lumo-size-xxs);
}

image

@javier-godoy javier-godoy added the enhancement New feature or request label Feb 3, 2023
@javier-godoy javier-godoy added this to Inbox (needs triage) in Flowing Code Addons (legacy) via automation Feb 3, 2023
@mlopezFC
Copy link
Member

I would go ahead without making it opt-in

@mlopezFC mlopezFC moved this from Inbox (needs triage) to To Do in Flowing Code Addons (legacy) Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To Do
Development

No branches or pull requests

2 participants