Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge in @flowforge/nr-* modules into this one #99

Open
7 of 8 tasks
knolleary opened this issue Jan 20, 2023 · 3 comments
Open
7 of 8 tasks

Merge in @flowforge/nr-* modules into this one #99

knolleary opened this issue Jan 20, 2023 · 3 comments
Assignees

Comments

@knolleary
Copy link
Member

knolleary commented Jan 20, 2023

We currently have the following modules pulled in by nr-launcher to create the Node-RED application we run in FlowForge:

  • @flowforge/nr-audit-logger
  • @flowforge/nr-auth
  • @flowforge/nr-storage
  • @flowforge/nr-theme
  • @flowforge/nr-persistent-context
  • @flowforge/nr-project-nodes
  • @flowforge/nr-file-nodes

That generates a lot of maintenance overhead around releases and when we have to synchronous PRs across multiple repos to deliver a new feature.

To reduce this burden, we're going to migrate some of those modules directly into the launcher. There was a proposal1 to roll them into a new repo that nr-launcher then depends on. However these no compelling reason to have them in another repo when they can just live directly in this one.

The proposal is to move:

  • @flowforge/nr-audit-logger
  • @flowforge/nr-auth
  • @flowforge/nr-storage
  • @flowforge/nr-theme

We will not move the following repos as they need to be loadable by the device agent so should be in their own modules.

  • @flowforge/nr-project-nodes
  • @flowforge/nr-file-nodes

That leaves @flowforge/nr-persistent-context to decide on. It is currently under the FF license, not Apache-2 as the feature it provides is only available on FF Premium.

I see two three options:

  • Keep it separate for now
  • Modify the license of this repo to be both Apache-2.0 and FF Premium (in the same model as the core ff repo is)
  • Relicense the code to Apache-2.0. I would argue we license the server side, but the client side should be openly license.

Given we have feature development planned on the context plugin in the current release, I'm inclined to leave it where it is for now. It can be rolled in at a later date.

Tasks

Footnotes

  1. https://github.com/flowforge/admin/issues/133

@knolleary
Copy link
Member Author

Aside from deciding what to do with persistent context, the work here is done for theme/audit/storage/auth.

@knolleary knolleary removed this from the 1.4 milestone Apr 27, 2023
@knolleary knolleary self-assigned this Apr 27, 2023
@hardillb
Copy link
Contributor

hardillb commented Jun 2, 2023

Should we open a new issue for persistent-context and close this one?

@knolleary
Copy link
Member Author

Whilst working on the npm package renaming work, I've decided we should roll persitent-context into nr-launcher and just be done with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants