Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permit Device Agent to automatically re-establish Editor Tunnel after a restart #220

Closed
wants to merge 6 commits into from
Closed

Permit Device Agent to automatically re-establish Editor Tunnel after a restart #220

wants to merge 6 commits into from

Conversation

Steve-Mcl
Copy link
Contributor

closes #147

Description

Stores the tunnel token and re-establishes the editor tunnel when restarting

Adds tests:

Agent
  loadsProject
    loads project file with a tunnel token
  setState
    Clears editorToken when switching off developer mode
  developer mode
    editor tunnel
      reconnects tunnel in developer mode when editorToken is set
      does not attempt to reconnect tunnel if not in developer mode (even if editorToken is set)
MQTT Comms
  Calls save token when commanded to startEditor

Updates tests:

Agent
  loadsProject
    saves project set for developer mode

Related Issue(s)

#147

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@knolleary
Merge pull request #220 from FlowFuse/147-auto-reconnect-tunnel
b48248f 
Permit Device Agent to automatically re-establish Editor Tunnel after a restart
@knolleary
Copy link
Member

Hmm - some github oddness happening. I've merged this PR, but it remains in open state saying there are conflicts... but as far as I can tell, the commits are already in main.

@Steve-Mcl Steve-Mcl closed this Jan 9, 2024
@Steve-Mcl Steve-Mcl deleted the 147-auto-reconnect-tunnel branch January 11, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Device Agent should automatically re-establish Editor Tunnel after a restart
3 participants
@Steve-Mcl @knolleary @hardillb