Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the bootstrap module to a proper launcher plugin #80

Open
Janrupf opened this issue Dec 29, 2020 · 0 comments
Open

Convert the bootstrap module to a proper launcher plugin #80

Janrupf opened this issue Dec 29, 2020 · 0 comments
Assignees
Labels
bug Something isn't working improvement An improvement to an existing feature

Comments

@Janrupf
Copy link
Contributor

Janrupf commented Dec 29, 2020

Description
The bootstrap module is a hack which should not exist in first place. The functionality of it should go into a launcher plugin, as it currently makes the launcher not standalone anymore by preloading jars.

Expected behavior
The bootstrap module is a launcher plugin instead of the hacky bootstrap.

Proposal

  1. The launcher starts up and begins its plugin loading cycle
  2. Bootstrap is the only launcher plugin which is initially on the path
  3. Bootstrap detects (or does not detect) an install of FlintMC
    4.1 FlintMC is not detected -> Bootstrap sets up a FlintMC install
    4.2 FlintMC is dectected -> Bootstrap verifies the integrity of the install and possibly checks for updates
  4. Bootstrap performs additional checks regarding installed mod compatibility
  5. Boostrap loads FlintMC launcher plugin and injects it using the provided mechanism
  6. The launcher finishes the first loading cycle and begins the second one
  7. The launch process continues as known
@Janrupf Janrupf added bug Something isn't working improvement An improvement to an existing feature labels Dec 29, 2020
@zortax zortax added this to To do in Flint Development Jan 7, 2021
@R0bbyYT R0bbyYT self-assigned this Jan 27, 2021
@R0bbyYT R0bbyYT moved this from To do to In progress in Flint Development Jan 27, 2021
@R0bbyYT R0bbyYT moved this from In progress to Review in progress in Flint Development Jan 27, 2021
@marcokruse marcokruse moved this from Review in progress to In progress in Flint Development Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working improvement An improvement to an existing feature
Projects
Development

No branches or pull requests

2 participants