Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin imdb fails to filter? #3866

Closed
once375ml opened this issue Oct 22, 2023 · 10 comments
Closed

Plugin imdb fails to filter? #3866

once375ml opened this issue Oct 22, 2023 · 10 comments
Labels
Stale

Comments

@once375ml
Copy link

once375ml commented Oct 22, 2023 •
edited

Expected behaviour:

Plugin imdb downloads rss torrents with given parameters.

Actual behaviour:

Plugin imdb can filter rss with given parameters, but it sill download the torrents of rss that donn't meet the given parameters.

Steps to reproduce:

  • Step 1: ...

Config:

web_server:
    bind: 0.0.0.0
    port: 5050
    web_ui: yes

tasks: 
  BDMru: 
    rss: https://kp.m-team.cc/torrentrss.php?https=1&rows=10&cat419=1&sta1=1&tea6=1&linktype=dl&passkey=
    accept_all: no
    if: 
      - "'1080p' in title": accept
      #- "'DEF' in title": reject
    #disable: 
    #  - seen
    #  - download
    download: /RssTorrents/BDMru
    #downloadstation: 
    #  hostname: localhost
    #  port: 5001 
    #  secure: true
    #  verify: false 
    #  username: 
    #  password: 
    #  dsm_version: 7
  MteamIMDB: 
    rss: https://kp.m-team.cc/torrentrss.php?https=1&rows=50&cat419=1&sta1=1&tea9=1&linktype=dl&passkey=
    accept_all: no
    if: 
      - "'1080p' in title": accept
      #- "'DEF' in title": reject
    imdb: 
      min_score: 6.1
      min_votes: 5000
      #reject_genres:
      #  - horror
    #disable: 
    #  - seen
    #  - download
    download: /RssTorrents/

schedules: 
  - tasks: [BDMru, MteamIMDB]
    #interval:
    #  minutes: 10
    schedule:
      minute: 30
      hour: 2, 4, 6, 8, 10, 12, 14, 16, 18, 20, 22
      #minute: 21
      #hour: 2, 5, 8, 11, 14, 17, 20, 23

Log:

(click to expand) 
2023-10-22 00:18:16 INFO     manager                       Config change detected. Reloading.
2023-10-22 00:18:16 INFO     manager                       Config successfully reloaded!
2023-10-22 00:19:39 INFO     imdb          Mteam_IMDB      Didn't accept `Ride On` because of rule(s) min_votes (4001 < 5000)
2023-10-22 00:19:39 INFO     imdb          Mteam_IMDB      Didn't accept `Meg 2: The Trench` because of rule(s) min_score (5.1 < 6.1)
2023-10-22 00:19:39 INFO     imdb          Mteam_IMDB      Didn't accept `The Dive` because of rule(s) min_score (5.6 < 6.1), min_votes (2346 < 5000)
2023-10-22 00:19:39 INFO     imdb          Mteam_IMDB      Didn't accept `3 Days in Malay` because of rule(s) min_score (3.9 < 6.1), min_votes (64 < 5000)
2023-10-22 00:19:39 INFO     imdb          Mteam_IMDB      Didn't accept `Mortal Kombat Legends: Cage Match` because of rule(s) min_score (6.0 < 6.1), min_votes (287 < 5000)
2023-10-22 00:19:39 INFO     imdb          Mteam_IMDB      Didn't accept `The Boogeyman` because of rule(s) min_score (5.9 < 6.1)
2023-10-22 00:19:39 INFO     imdb          Mteam_IMDB      Didn't accept `Mob Land` because of rule(s) min_score (5.2 < 6.1), min_votes (1458 < 5000)
2023-10-22 00:19:39 INFO     imdb          Mteam_IMDB      Didn't accept `The Engineer` because of rule(s) min_score (3.8 < 6.1), min_votes (899 < 5000)
2023-10-22 00:19:39 INFO     imdb          Mteam_IMDB      Didn't accept `Sympathy for the Devil` because of rule(s) min_score (5.5 < 6.1)
2023-10-22 00:19:39 INFO     imdb          Mteam_IMDB      Didn't accept `Ruby Gillman, Teenage Kraken` because of rule(s) min_score (5.7 < 6.1)
2023-10-22 00:19:39 INFO     imdb          Mteam_IMDB      Didn't accept `Natty Knocks` because of rule(s) min_score (4.2 < 6.1), min_votes (688 < 5000)
2023-10-22 00:19:39 INFO     imdb          Mteam_IMDB      Didn't accept `Lonely Castle in the Mirror` because of rule(s) min_votes (553 < 5000)
2023-10-22 00:19:39 INFO     imdb          Mteam_IMDB      Didn't accept `Insidious: The Red Door` because of rule(s) min_score (5.5 < 6.1)
2023-10-22 00:19:39 INFO     imdb          Mteam_IMDB      Didn't accept `Gangnam Zombie` because of rule(s) min_score (3.2 < 6.1), min_votes (584 < 5000)
2023-10-22 00:19:39 INFO     imdb          Mteam_IMDB      Didn't accept `Prisoner's Daughter` because of rule(s) min_votes (1440 < 5000)
2023-10-22 00:19:39 INFO     imdb          Mteam_IMDB      Didn't accept `Cobweb` because of rule(s) min_score (5.9 < 6.1)
2023-10-22 00:19:39 INFO     imdb          Mteam_IMDB      Didn't accept `My Flying Wife` because of rule(s) min_score (5.7 < 6.1), min_votes (96 < 5000)
2023-10-22 00:19:39 INFO     imdb          Mteam_IMDB      Didn't accept `Bad City` because of rule(s) min_score (5.8 < 6.1), min_votes (366 < 5000)
2023-10-22 00:19:39 INFO     imdb          Mteam_IMDB      Didn't accept `Hidden Enforcers` because of rule(s) min_score (4.5 < 6.1), min_votes (77 < 5000)
2023-10-22 00:19:39 INFO     imdb          Mteam_IMDB      Didn't accept `God Is a Bullet` because of rule(s) min_score (5.6 < 6.1), min_votes (3684 < 5000)
2023-10-22 00:19:39 INFO     imdb          Mteam_IMDB      Didn't accept `Goodbye Monster` because of rule(s) min_votes (172 < 5000)
2023-10-22 00:19:39 INFO     imdb          Mteam_IMDB      Didn't accept `Aporia` because of rule(s) min_score (5.3 < 6.1), min_votes (513 < 5000)
2023-10-22 00:19:39 INFO     imdb          Mteam_IMDB      Skipping The Lady Assassin 1991 1080p myTV-SUPER WEB-DL H265 AAC-ManGor@MTeam because of an error: IMDB lookup failed for The Lady Assassin 1991 1080p myTV-SUPER WEB-DL H265 AAC-ManGor@MTeam
2023-10-22 00:19:40 INFO     imdb          Mteam_IMDB      Didn't accept `Metalocalypse: Army of the Doomstar` because of rule(s) min_votes (652 < 5000)
2023-10-22 00:19:40 INFO     imdb          Mteam_IMDB      Didn't accept `From Black` because of rule(s) min_score (5.0 < 6.1), min_votes (1709 < 5000)
2023-10-22 00:19:40 INFO     imdb          Mteam_IMDB      Skipping Hotel Transylvania 4 Transformania 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam because of an error: IMDB lookup failed for Hotel Transylvania 4 Transformania 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:19:40 INFO     imdb          Mteam_IMDB      Didn't accept `The Machine` because of rule(s) min_score (5.8 < 6.1)
2023-10-22 00:19:40 INFO     imdb          Mteam_IMDB      Didn't accept `Kill Shot` because of rule(s) min_score (5.3 < 6.1), min_votes (1234 < 5000)
2023-10-22 00:19:40 INFO     imdb          Mteam_IMDB      Didn't accept `Confidential Informant` because of rule(s) min_score (4.5 < 6.1), min_votes (2204 < 5000)
2023-10-22 00:19:40 INFO     imdb          Mteam_IMDB      Didn't accept `Babylon 5: The Road Home` because of rule(s) min_votes (1055 < 5000)
2023-10-22 00:19:40 INFO     imdb          Mteam_IMDB      Didn't accept `97 Minutes` because of rule(s) min_score (3.5 < 6.1), min_votes (1341 < 5000)
2023-10-22 00:19:40 INFO     imdb          Mteam_IMDB      Didn't accept `River Wild` because of rule(s) min_score (5.5 < 6.1), min_votes (3912 < 5000)
2023-10-22 00:19:40 INFO     imdb          Mteam_IMDB      Didn't accept `Maggie Moore(s)` because of rule(s) min_votes (3368 < 5000)
2023-10-22 00:19:40 INFO     imdb          Mteam_IMDB      Didn't accept `Fast X` because of rule(s) min_score (5.8 < 6.1)
2023-10-22 00:19:40 INFO     imdb          Mteam_IMDB      Didn't accept `Resident Evil: Death Island` because of rule(s) min_score (5.7 < 6.1)
2023-10-22 00:19:40 INFO     download      Mteam_IMDB      Downloading: Ride On 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:19:44 INFO     download      Mteam_IMDB      Downloading: Meg 2 The Trench 2023 BluRay 1080p TrueHD 7 1 x264-MTeam
2023-10-22 00:19:45 INFO     download      Mteam_IMDB      Downloading: The Dive 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:19:46 INFO     download      Mteam_IMDB      Downloading: 3 Days in Malay 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:19:49 INFO     download      Mteam_IMDB      Downloading: Haunted Mansion 2023 BluRay 1080p DTS-HD MA 7 1 x264-MTeam
2023-10-22 00:19:50 INFO     download      Mteam_IMDB      Downloading: Mortal Kombat Legends Cage Match 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:19:51 INFO     download      Mteam_IMDB      Downloading: Barbie 2023 BluRay 1080p TrueHD 7 1 x264-MTeam
2023-10-22 00:19:52 INFO     download      Mteam_IMDB      Downloading: The Boogeyman 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:19:53 INFO     download      Mteam_IMDB      Downloading: Transformers Rise of the Beasts 2023 BluRay 1080p TrueHD 7 1 x264-MTeam
2023-10-22 00:19:54 INFO     download      Mteam_IMDB      Downloading: Talk to Me 2022 BluRay 1080p TrueHD 7 1 x264-MTeam
2023-10-22 00:19:55 INFO     download      Mteam_IMDB      Downloading: Mob Land 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:19:56 INFO     download      Mteam_IMDB      Downloading: The Engineer 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:19:58 INFO     download      Mteam_IMDB      Downloading: Sympathy for the Devil 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:19:59 INFO     download      Mteam_IMDB      Downloading: Ruby Gillman Teenage Kraken 2023 BluRay 1080p TrueHD 7 1 x264-MTeam
2023-10-22 00:20:00 INFO     download      Mteam_IMDB      Downloading: Natty Knocks 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:20:01 INFO     download      Mteam_IMDB      Downloading: Lonely Castle in the Mirror 2022 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:20:02 INFO     download      Mteam_IMDB      Downloading: Insidious The Red Door 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:20:03 INFO     download      Mteam_IMDB      Downloading: Gangnam Zombie 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:20:04 INFO     download      Mteam_IMDB      Downloading: Elemental 2023 BluRay 1080p DTS-HD MA 7 1 x264-MTeam
2023-10-22 00:20:05 INFO     download      Mteam_IMDB      Downloading: Past Lives 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:20:06 INFO     download      Mteam_IMDB      Downloading: Prisoner's Daughter 2022 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:20:07 INFO     download      Mteam_IMDB      Downloading: Joy Ride 2023 BluRay 1080p TrueHD 7 1 x264-MTeam
2023-10-22 00:20:08 INFO     download      Mteam_IMDB      Downloading: Cobweb 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:20:09 INFO     download      Mteam_IMDB      Downloading: My Flying Wife 1991 1080p myTV-SUPER WEB-DL H265 AAC-ManGor@MTeam
2023-10-22 00:20:11 INFO     download      Mteam_IMDB      Downloading: Bad City 2022 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:20:13 INFO     download      Mteam_IMDB      Downloading: The Little Mermaid 2023 BluRay 1080p DTS-HD MA 7 1 x264-MTeam
2023-10-22 00:20:14 INFO     download      Mteam_IMDB      Downloading: The Hidden Enforcers 2002 1080p myTV-SUPER WEB-DL H265 AAC-ManGor@MTeam
2023-10-22 00:20:15 INFO     download      Mteam_IMDB      Downloading: God Is a Bullet 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:20:26 INFO     download      Mteam_IMDB      Downloading: Goodbye Monster 2022 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:20:27 INFO     download      Mteam_IMDB      Downloading: Aporia 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:20:28 INFO     download      Mteam_IMDB      Downloading: Air 2023 BluRay 1080p TrueHD 7 1 x264-MTeam
2023-10-22 00:20:29 INFO     download      Mteam_IMDB      Downloading: Spider-Man Across the Spider-Verse 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:20:30 INFO     download      Mteam_IMDB      Downloading: No Hard Feelings 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:20:31 INFO     download      Mteam_IMDB      Downloading: The Flash 2023 BluRay 1080p TrueHD 7 1 x264-MTeam
2023-10-22 00:20:32 INFO     download      Mteam_IMDB      Downloading: The Lady Assassin 1991 1080p myTV-SUPER WEB-DL H265 AAC-ManGor@MTeam
2023-10-22 00:20:33 INFO     download      Mteam_IMDB      Downloading: Metalocalypse Army of the Doomstar 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:20:35 INFO     download      Mteam_IMDB      Downloading: From Black 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:20:36 INFO     download      Mteam_IMDB      Downloading: Nefarious 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:20:37 INFO     download      Mteam_IMDB      Downloading: Hotel Transylvania 4 Transformania 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:20:38 INFO     download      Mteam_IMDB      Downloading: Asteroid City 2023 BluRay 1080p DTS-HD MA 7 1 x264-MTeam
2023-10-22 00:20:39 INFO     download      Mteam_IMDB      Downloading: The Machine 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:20:40 INFO     download      Mteam_IMDB      Downloading: Kill Shot 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:20:42 INFO     download      Mteam_IMDB      Downloading: Confidential Informant 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:20:43 INFO     download      Mteam_IMDB      Downloading: Babylon 5 The Road Home 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:20:45 INFO     download      Mteam_IMDB      Downloading: 97 Minutes 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:20:47 INFO     download      Mteam_IMDB      Downloading: The River Wild 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:20:48 INFO     download      Mteam_IMDB      Downloading: Maggie Moore(s) 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:20:49 INFO     download      Mteam_IMDB      Downloading: Fast X 2023 BluRay 1080p TrueHD 7 1 x264-MTeam
2023-10-22 00:20:50 INFO     download      Mteam_IMDB      Downloading: Resident Evil Death Island 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam
2023-10-22 00:20:51 INFO     download      Mteam_IMDB      Downloading: Guardians of the Galaxy Vol 3 2023 BluRay 1080p DTS-HD MA 7 1 x264-MTeam

Additional information:

  • FlexGet version:
  • Python version:
  • Installation method:
  • Using daemon (yes/no):
  • OS and version:
  • Link to crash log:
@gazpachoking
Copy link
Member

The imdb plugin accepts movies that pass its filter. You are also accepting things with the 'if' plugin (thus bypassing the imdb plugin.) If you change to rejecting things that you don't want it should work as expected.
i.e.

if:
  - "'1080p' not in title":  reject

But better than that would probably be to use the quality plugin, which will reject all entries that don't match the specified quality.

quality: 1080p

@once375ml
Copy link
Author

The imdb plugin accepts movies that pass its filter. You are also accepting things with the 'if' plugin (thus bypassing the imdb plugin.) If you change to rejecting things that you don't want it should work as expected. i.e.

if:
  - "'1080p' not in title":  reject

But better than that would probably be to use the quality plugin, which will reject all entries that don't match the specified quality.

quality: 1080p

Thanks for your suggestion about the quality filter.

But if you look at the log, it shows(take one item for example):

2023-10-22 00:19:39 INFO     imdb          Mteam_IMDB      Didn't accept `Ride On` because of rule(s) min_votes (4001 < 5000)

...

2023-10-22 00:19:40 INFO     download      Mteam_IMDB      Downloading: Ride On 2023 BluRay 1080p DTS-HD MA 5.1 x264-MTeam

Now that imdb had identified the votes didn't meet the parameter, why flexget downloaded it?

@gazpachoking
Copy link
Member

Now that imdb had identified the votes didn't meet the parameter, why flexget downloaded it?

Because you had the 'if' plugin accept it.

@once375ml
Copy link
Author

once375ml commented Oct 22, 2023 •
edited

Now that imdb had identified the votes didn't meet the parameter, why flexget downloaded it?

Because you had the 'if' plugin accept it.

So, the logic between filters is "or" ?

@gazpachoking
Copy link
Member

gazpachoking commented Oct 22, 2023 •
edited

Yes, for an entry to pass the filter phase, at least one plugin must accept it, and no plugins can reject it. The normal paradigm is to have one main plugin that does the accepting, (e.g. imdb, series, list_match,) and possibly other plugins that do rejecting to further filter down the list (e.g. quality, content_size, regexp.)

@once375ml
Copy link
Author

Yes, for an entry to pass the filter phase, at least one plugin must accept it, and no plugins can reject it. The normal paradigm is to have one main plugin that does the accepting, (e.g. imdb, series, list_match,) and possibly other plugins that do rejecting to further filter down the list (e.g. quality, content_size, regexp.)

Nice strategy！
New to Flexget, I need to learn further.

Feedback: imdb filter works now. Thank you all!

@once375ml
Copy link
Author

once375ml commented Oct 25, 2023 •
edited

Yes, for an entry to pass the filter phase, at least one plugin must accept it, and no plugins can reject it. The normal paradigm is to have one main plugin that does the accepting, (e.g. imdb, series, list_match,) and possibly other plugins that do rejecting to further filter down the list (e.g. quality, content_size, regexp.)

New problem comes up.

When I wrote my task as you recommended.

tasks: 
  BDMru: 
    rss: https://kp.m-team.cc/torrentrss.php?https=1&rows=10&cat419=1&sta1=1&tea6=1&linktype=dl&passkey=
    accept_all: no
    quality: 1080p
    download: /RssTorrents/BDMru

The log said:

Task didn't produce any entries. This is likely due to a mis-configured or non-functional input.

It seems the "quality" filter doesn't work at all.

BDMru: 
    rss: https://kp.m-team.cc/torrentrss.php?https=1&rows=10&cat419=1&sta1=1&tea6=1&linktype=dl&passkey=
    accept_all: no
    if: 
      - "'1080p' in title": accept    
    download: /RssTorrents/BDMru

When I return to my old one, it works.

Is the format of the RSS not compatable with the filter "quality"? What does the "quality" filter base on? Title of each RSS items? I am sure these titles do contain the key word "1080p".

@BrutuZ
Copy link
Contributor

BrutuZ commented Oct 25, 2023

Quality doesn't accept entries, just rejects the ones that don't match it.
accept_all: no is irrelevant BTW, entries are undecided by default.

@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 150 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Mar 23, 2024
@github-actions GitHub Actions
Copy link

This issue has been stale for 30 days and is being closed.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gazpachoking @once375ml @BrutuZ