Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: a combination of loose and optimistic for release estimations #3614

Closed
girtsl opened this issue Nov 23, 2022 · 4 comments · May be fixed by #3650
Closed

Feature request: a combination of loose and optimistic for release estimations #3614

girtsl opened this issue Nov 23, 2022 · 4 comments · May be fixed by #3650
Labels
Enhancement Stale

Comments

@girtsl
Copy link
Contributor

girtsl commented Nov 23, 2022

https://flexget.com/Plugins/discover

loose will check for release dates, if release date can not be determined perform search anyway.
optimistic sets the estimation mode to strict but starts searching interval units (eg. 7 days) before release date.

The recommended option is optimistic but this will prevent flexget from searching for movies that don't have a release date on blu-ray.com. This should be covered by loose - it will perform the search anyway but apparently honors the release date reported by blu-ray.com - and I've observed that sometimes releases are available much sooner than that.
Since neither of these options suit me I'm forced to use ignore which will make flexget search for movies which have obviously not yet released - making dozens of unnecessary requests.

Ideally I would like to have a combination of loose and optimistic - i.e. have loose accept interval units just like optimistic does.
@aidan- aidan- mentioned this issue Jan 3, 2023
Open
2 tasks
@aidan-
Copy link
Contributor

aidan- commented Jan 3, 2023

@girtsl I've had a crack at implementing this in #3650 - it'd be great if you could give it a test and make sure it fits your requirements.

@girtsl
Copy link
Contributor Author

girtsl commented Jan 4, 2023

@aidan-, thanks for taking a stab at this. Unfortunately I don't have an environment where I could test this and verify that it covers the cases I put forth but I have a few comments.

I had 2 cases to cover:

  • when the release date cannot be determined, the search would be performed anyway;
  • if the release date can be determined, perform the search {interval} before it.

I was not able to test this and by reading the PR's source code I was not able to determine if the first case would be covered (I'm a Python noob, though), perhaps the behavior is implicit.
However, not only are the changes in #3650 breaking, IMO they are also not very intuitive - where there was just one configuration option (release_estimations), now there are two. The interval is also not relevant to all modes (it seems most of them would ignore it). This is for the maintainers to decide though.

@github-actions
Copy link

github-actions bot commented Jun 4, 2023

This issue is stale because it has been open 150 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Jun 4, 2023
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

This issue has been stale for 30 days and is being closed.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[change] estimate_release - make configurable aidan-/Flexget
3 participants
@gazpachoking @aidan- @girtsl