fix: deprecated decorator wasn't returning the value of the moved cal…

[victorgarcia98]

While trying to the decorator @deprecated to refactor a function signature, I realized that is not returning the value of the function, just calling it.

This bug affects the following functions:

• flexmeasures.data.queries.data_sources:get_or_create_source
• flexmeasures.data.queries.data_sources:get_source_or_none
• flexmeasures.data.services.asset_grouping:get_asset_group_queries

and methods:

• flexmeasures.data.models.planning:Scheduler.compute_schedule
• flexmeasures.data.models.planning:storage:StorageScheduler.compute_schedule

This is specially concerning for code extending from Scheduler.

[nhoening]

Great catch!

Hm, so this affects functions we are not using internally anymore, but it might have led to errors in other people's code, who have been using them, correct? Something that easily slips your own testing, of course, if you're not using them anymore :/

In my eyes, maybe the scheduling ones have a small likelihood that this actually happened.
Have we officially released this broken deprecation in version 0.13?

[nhoening]

In that case, we might want to add this to version 0.13.1. @Flix6x knows how that works.

[victorgarcia98]

Hm, so this affects functions we are not using internally anymore, but it might have led to errors in other people's code, who have been using them, correct?

That's correct, this affects external code.

Have we officially released this broken deprecation in version 0.13?

yes, we have 😞, see here.

[Flix6x]

🥇