FLEXMEASURES_PLUGINS configurable from env #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
…parated string; document wich settings are also read as env vars Signed-off-by: Nicolas Höning <nicolas@seita.nl>
…RES_PLUGINS setting Signed-off-by: Nicolas Höning <nicolas@seita.nl>
nhoening
changed the title
Flix6x
requested changes
May 3, 2023
There was a problem hiding this comment.
Still needs an actual changelog entry, I think. And we might need to update some plugin documentation if anything still uses the sunset way. I also noticed the deprecation notice was set to "debug" level, which may have been too subtle to notice. I'd recommend not sunsetting right now and increasing the logging level instead first.
|
@Flix6x I agree in principle that we should pre-announce removal of config settings. In this case, it lived only a few weeks about 18 months ago. We did, however, mention it in the Readmes of the entsoe- and zinfo-plugins. The former might have been implemented by somebody, so I will upgrade the log level and warn in the release notes. |
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
victorgarcia98
approved these changes
May 5, 2023
Flix6x
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FLEXMEASURES_PLUGINS settings should also be possible as an env var. This is handy for devs, who simply want to add their own logic, but are not busy with how FlexMeasures works or is deployed. For example, they use a docker-compose or Kubernetes setup and just add their logic.