Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support blackout tests #651

Merged
merged 46 commits into from May 1, 2023
Merged

Support blackout tests #651

merged 46 commits into from May 1, 2023

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Apr 28, 2023 •
edited

To try out:

  • Navigate to http://localhost:5000/api/v2_0/getService and get a 410 (Gone)
  • Set FLEXMEASURES_API_1_AND_2_SUNSET_ACTIVE = False in your flexmeasures.cfg
  • Refresh http://localhost:5000/api/v2_0/getService and get a regular service listing

@Flix6x
remove tests already present in v3
88c6a42 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
move asset deletion test to v3
f633cdb 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
move asset creation test to v3
3bcd8f1 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
remove last remaining asset test from v2
d7b0c39 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
stop testing post_price_data and post_prognosis on v2
c4e34c4 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
move test scheduling with unknown prices from v1.3 to v3
c197cdf 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
remove v1.3 test already present in v3
80bba2c 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
move test for wrong job id from v1.3 to v3
66b374b 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
no tests worth moving in v1.2
5c21e2b 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
remove test for posting weather data from v1.1
fea604a 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
move test for posting data with incompatible resolution from v1.1 to v3
0f3cee5 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
move test for posting data with a user that is not properly set up as…
e29d20a 
… a data source, from v1.1 to v3; also test posting is not allowed for inactive admins

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
move test for getting data for an empty period from v1.1 to v3
a5236a9 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
move v3 tests that just GET data to test module that uses db fixture …
a95864b 
…rather than fresh_db fixture

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
remove v1.1 test utils including old simulation script that uses one …
3f37be1 
…of them

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
salvage only 1 test from v1, which logs out a user
900d9e2 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
add missing fixtures to let tests succeed on their own, too
73cfe29 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
remove v1.0 test utils
0a7fd46 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
add changelog warning
316ed0b 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
update API documentation
62b0b34 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Document public endpoints in v3
51e665d 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
black
62c5ef5 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Implement getService for API v3
928510b 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Document service listing for v3
4c7780c 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Show quickref contents rather than summary line of docstring
d94d780 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Fix removal of suffix and prefix, by not using rstrip and lstrip, res…
c966746 
…pectively

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
API changelog entry
250dd54 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Make getService more RESTful
fe22428 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Add warning to API developer docs
ee3d176 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
More robust against spaces
81b0600 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Support blackout tests
1b8266d 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x requested a review from nhoening April 28, 2023 11:31
@Flix6x Flix6x self-assigned this Apr 28, 2023
@Flix6x
black
d6b6d05 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Fix test
ade6713 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
More specific if statement
25db921 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@coveralls
Copy link
Collaborator

coveralls commented Apr 28, 2023 •
edited

Pull Request Test Coverage Report for Build 4831471117

  • 27 of 41 (65.85%) changed or added relevant lines in 8 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 55.612%
Changes Missing Coverage Covered Lines Changed/Added Lines %
flexmeasures/api/common/utils/deprecation_utils.py 12 26 46.15%
Files with Coverage Reduction New Missed Lines %
flexmeasures/api/common/utils/deprecation_utils.py 2 34.15%
Totals Coverage Status
Change from base Build 4812786221: -0.007%
Covered Lines: 6323
Relevant Lines: 10241
💛 - Coveralls

@Flix6x
change default to activating the sunset
9c56501 
Signed-off-by: F.N. Claessen <felix@seita.nl>
nhoening
nhoening requested changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I did not have the setting yet, the API (2.0) was still sunset, so that contradicts your test instructions for this PR, bus still seems correct to me.
I found one potential problem.

flexmeasures/api/common/utils/deprecation_utils.py Show resolved Hide resolved
flexmeasures/api/common/utils/deprecation_utils.py Outdated Show resolved Hide resolved
@Flix6x
Add sunset documentation for FlexMeasures hosts and make the config s…
733a244 
…ettings reusable for future sunsets

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
shorten comment
7d3ab42 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
fix override from config setting
522634f 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
refactor
9126a14 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Copy link
Contributor Author

Flix6x commented Apr 28, 2023

When I did not have the setting yet, the API (2.0) was still sunset, so that contradicts your test instructions for this PR, bus still seems correct to me. I found one potential problem.

I had failed to update my introductions after changing the default to having the sunset activated. I have revised my instructions now.

@Flix6x Flix6x requested a review from nhoening April 28, 2023 14:13
@Flix6x Flix6x mentioned this pull request Apr 28, 2023
Merged
8 tasks
nhoening
nhoening reviewed Apr 28, 2023
View reviewed changes
documentation/api/introduction.rst Outdated Show resolved Hide resolved
flexmeasures/api/common/utils/deprecation_utils.py Show resolved Hide resolved
flexmeasures/api/v1_3/__init__.py Outdated Show resolved Hide resolved
@Flix6x
Cross reference to snapshot version of API documentation
5164c8f 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
We want to support blackout tests already from the version that annou…
5fee35c 
…nces the deprecation and sunset

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
black
76284b4 
Signed-off-by: F.N. Claessen <felix@seita.nl>
Flix6x added 2 commits May 1, 2023 13:04
@Flix6x
Add cross-reference and explanation, and add clarity
0d8e6cc 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Customize admonition
1c2a181 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x requested a review from nhoening May 1, 2023 11:56
Base automatically changed from sunset-api-versions-1-and-2 to main May 1, 2023 13:34
@Flix6x Flix6x added this to the 0.13.0 milestone May 1, 2023
@Flix6x Flix6x merged commit 0791fa3 into main May 1, 2023
6 of 7 checks passed
@Flix6x Flix6x deleted the support-blackout-tests branch May 1, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening approved these changes

Assignees

@Flix6x Flix6x

Labels
None yet
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Flix6x @coveralls @nhoening