Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix copybutton #636

Merged
merged 7 commits into from Apr 13, 2023
Merged

Fix copybutton #636

merged 7 commits into from Apr 13, 2023

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Apr 13, 2023 •
edited

This PR fixes the copy button on tutorials and other documentation, so that only commands are copied and no output or comments.

@Flix6x
typo
27b4bd4 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Fix bash console code blocks
b9a81f5 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Python code block
6d459bc 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
We've moved from Bitbucket to GitHub long ago
4e48e6b 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Changelog entry
63bef44 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added the documentation Improvements or additions to documentation label Apr 13, 2023
@Flix6x Flix6x self-assigned this Apr 13, 2023
@Flix6x Flix6x added this to the 0.13.0 milestone Apr 13, 2023
@coveralls
Copy link
Collaborator

coveralls commented Apr 13, 2023 •
edited

Pull Request Test Coverage Report for Build 4687372174

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.5%
Totals Coverage Status
Change from base Build 4678022234: 0.0%
Covered Lines: 6940
Relevant Lines: 10012
💛 - Coveralls

@Flix6x
Update sensor ids in the docker-compose documentation, too
96ee2b8 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Update sensor ids and CLI option
a4ab9ce 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x requested a review from nhoening April 13, 2023 10:19
nhoening
nhoening approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, and I confirm it fixes it.

But I still don't understand how this got broken, as it used to work earlier.
We have used console right from the beginning, in #381 and #416 ...

@Flix6x Flix6x merged commit dc99c5b into main Apr 13, 2023
5 checks passed
@Flix6x Flix6x deleted the fix-copybutton branch April 13, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening approved these changes

Assignees

@Flix6x Flix6x

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Flix6x @coveralls @nhoening