New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI Text Styles and pre-commit configuration #609
Conversation
…e system installed version. Issue FlexMeasures#608 Signed-off-by: victor <victor@seita.nl>
…ccess, warn, error. The different styles, which are nothing but attributes of the function , are stored as dictionaries. Signed-off-by: victor <victor@seita.nl>
Signed-off-by: victor <victor@seita.nl>
Signed-off-by: victor <victor@seita.nl>
I think the name of this development branch is a bit confusing. @nhoening what do you suggest? Rename and recreate this PR? |
I believe the branch name is not that relevant, what we want to control is the commit message of the merge commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. I got a few requests, but nothing serious.
Out of interest - have you checked how click.UsageError
is styling the error messages?
Signed-off-by: victor <victor@seita.nl>
Pull Request Test Coverage Report for Build 4488267179
💛 - Coveralls |
I'm just pushed the changes you requested. Moreover, I have harmonized the raise of exceptions (all By the way, I think we need to standardize the way we exit the CLI commands in case of an error. In some places, there is just a Please, let me know if it is fine like this or we should distinguish between 'code errors' (exceptions) and 'operational errors' (invalid operations). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve, just one small fix left.
The danger with this one of course is that our test coverage of the CLI commands is very bad. We have flake8 etc for a little help.
It's easy to overlook one small mistake and ruin a command until someone tries it.
How many commands did you try manually, to see if they work?
Signed-off-by: victor <victor@seita.nl>
Closes #603