Fix 588: CLI command add schedule for-storage not working without --as-job #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(which affects all sensors) if we have no sensor_id Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Pull Request Test Coverage Report for Build 4091774821
💛 - Coveralls |
Flix6x
approved these changes
Feb 4, 2023
Flix6x
added
Still Needs Manual Backport
Still Needs Changelog Entry
bug
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
nhoening
deleted the
588-cli-add-schedule-for-storage-not-working-in-toy-example
branch
Flix6x
pushed a commit
that referenced
this pull request
Feb 4, 2023
…ing without --as-job (#589) * when deleting prognoses, only delete forecasting and scheduling jobs (which affects all sensors) if we have no sensor_id Signed-off-by: Nicolas Höning <nicolas@seita.nl> * Fix parameters for make_schedule in add schedule for-storage CLI command Signed-off-by: Nicolas Höning <nicolas@seita.nl> * add a docstring Signed-off-by: Nicolas Höning <nicolas@seita.nl> --------- Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #588
This only affects usage without --as-job