Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix validation of deprecated roundtrip-efficiency field in trigger-schedules endpoint #582

Merged
merged 2 commits into from Jan 12, 2023
Merged

fix validation of deprecated roundtrip-efficiency field in trigger-schedules endpoint #582

merged 2 commits into from Jan 12, 2023

Conversation

nhoening
Copy link
Contributor

Fixes #581

@nhoening
fix validation of deprecated roundtrip-efficiency field in trigger-sc…
33c8ab8 
…hedules endpoint

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening requested a review from Flix6x January 11, 2023 20:54
@coveralls
Copy link
Collaborator

coveralls commented Jan 11, 2023 •
edited

Pull Request Test Coverage Report for Build 3896942512

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.517%
Totals Coverage Status
Change from base Build 3845351217: 0.0%
Covered Lines: 6869
Relevant Lines: 9852
💛 - Coveralls

Flix6x
Flix6x approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs a change log entry for 0.12.1. I can handle the backport and patch release (as I usually do that).

@nhoening
add changelog entry
9fb4911 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@Flix6x Flix6x added this to the 0.12.1 milestone Jan 11, 2023
@Flix6x Flix6x merged commit 08938a5 into main Jan 12, 2023
@Flix6x Flix6x deleted the fix-deprecated-roundtripefficiency-api-parameter-validation branch January 12, 2023 07:58
Flix6x pushed a commit that referenced this pull request Jan 12, 2023
@nhoening @Flix6x
Backport PR #582: fix validation of deprecated roundtrip-efficiency f…
dec4b4d 
…ield in trigger-schedules endpoint (#582)

Fixes #581.

* fix validation of deprecated roundtrip-efficiency field in trigger-schedules endpoint

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* add changelog entry

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flix6x Flix6x Flix6x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.1
Development

Successfully merging this pull request may close these issues.

Deprecated roundtrip-efficiency field only works as a string
3 participants
@nhoening @coveralls @Flix6x