Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how clients can monitor deprecation and sunset response headers #565

Merged
merged 5 commits into from Dec 29, 2022
Merged

Document how clients can monitor deprecation and sunset response headers #565

merged 5 commits into from Dec 29, 2022

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Dec 29, 2022

No description provided.

@Flix6x
Clarify use of None values in test util
2fb60e1 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
HTTP headers are allowed to contain multiple keys with the same name
32e74c7 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Add client-side code example to API introduction, showing how to moni…
325cff9 
…tor the response headers for deprecation and sunset warnings

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Changelog entry
76e4448 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Missing API changelog entries for introducing new API documentation s…
e74cf23 
…ubsections

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added documentation Improvements or additions to documentation API deprecation labels Dec 29, 2022
@Flix6x Flix6x self-assigned this Dec 29, 2022
@Flix6x Flix6x requested a review from nhoening December 29, 2022 14:39
@Flix6x Flix6x added this to the 0.12.0 milestone Dec 29, 2022
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3801241156

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 65.579%
Totals Coverage Status
Change from base Build 3799912902: 0.005%
Covered Lines: 6839
Relevant Lines: 9800
💛 - Coveralls

nhoening
nhoening approved these changes Dec 29, 2022
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition !

@Flix6x Flix6x merged commit 02299a5 into main Dec 29, 2022
@Flix6x Flix6x deleted the extend-reponse-headers branch December 29, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening approved these changes

Assignees

@Flix6x Flix6x

Labels
API deprecation documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Flix6x @coveralls @nhoening