548 allow sending null values when posting data #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
|
I agree. |
…tead Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…l-values-when-posting-data
Signed-off-by: F.N. Claessen <felix@seita.nl>
nhoening
approved these changes
Dec 8, 2022
Flix6x
added a commit
to SeitaBV/v2g-liberty
that referenced
this pull request
Dec 30, 2022
Send null values instead of -1 values, which avoids recording -1 values in FlexMeasures, while still correctly spacing the data sent. This is possible since FlexMeasures/flexmeasures#549. * Send null values instead of -1, which avoids recording -1 values in FlexMeasures while still correctly spacing the data sent * Fix comparison of None with int (minimum SoC) * Compare to min SoC setting instead of hardcoded value * Add car_min_soc_in_percent in set_fm_data config settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nhoening Would you agree that the values should not enter the database as NaN values? That is, users may send null values in order to correctly 'space' their time series data, but we'd then throw them out before saving.