New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monitor users by time since last request #541
Conversation
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Pull Request Test Coverage Report for Build 3633712562
💛 - Coveralls |
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spent most of my review time on understanding why a potential timezone issue I noticed wasn't causing problems. Feel free to make a separate ticket for that, because I know that timezone issues can keep you occupied for a long time, and your code doesn't actually have a problem at this point.
My only actual concern is missing opt-in / opt-out functionality. Not asking to implement that, but some documentation warning the admin about sending emails to users without them being able to opt out seems prudent.
Otherwise, only a few (other) touches to the documentation.
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with grammar fixes.
Sidenote: Any reason why you didn't update the logic in |
Actually, I overlooked the logic change you proposed. Thanks! |
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
… edits to messages Signed-off-by: Nicolas Höning <nicolas@seita.nl>
This feature is useful for those user accounts which are expected to send/get data in automated fashion.
If they don't connect in the expected frequency, something's wrong - probably at their side. They will get alerts, just as the usual FlexMeasures operators.