Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix creation of assets from CLI #497

Merged
merged 4 commits into from Sep 6, 2022
Merged

Fix creation of assets from CLI #497

merged 4 commits into from Sep 6, 2022

Conversation

nhoening
Copy link
Contributor

@nhoening nhoening commented Sep 6, 2022

Closes #496

@nhoening
allow to create assets from CLI (lighten restriction in input validat…
5d620fe 
…ion)

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
small refactoring to use auth logic
dc2cdd4 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening requested a review from Flix6x September 6, 2022 09:29
@coveralls
Copy link
Collaborator

coveralls commented Sep 6, 2022 •
edited

Pull Request Test Coverage Report for Build 2999821400

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 65.106%
Totals Coverage Status
Change from base Build 2999633885: 0.005%
Covered Lines: 6475
Relevant Lines: 9340
💛 - Coveralls

Flix6x
Flix6x approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This would go towards 0.11.2 right?

@nhoening
Copy link
Contributor Author

nhoening commented Sep 6, 2022

Yes, that would be good. Any other things for that currently?

@Flix6x Flix6x added this to the 0.11.2 milestone Sep 6, 2022
@Flix6x
Merge remote-tracking branch 'origin/main' into Issue-496-CLI-cannot-…
65d03a7 
…create-assets
@Flix6x
Changelog entry
6b206a1 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x merged commit 51aa6aa into main Sep 6, 2022
@Flix6x Flix6x deleted the Issue-496-CLI-cannot-create-assets branch September 6, 2022 11:34
Flix6x added a commit that referenced this pull request Sep 6, 2022
@nhoening @Flix6x
Backport PR #497: Fix creation of assets from CLI (#497)
b2a9ce2 
Fix broken auth check for creating assets with CLI.

* allow to create assets from CLI (lighten restriction in input validation)

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* small refactoring to use auth logic

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* Changelog entry

Signed-off-by: F.N. Claessen <felix@seita.nl>

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Co-authored-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flix6x Flix6x Flix6x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.2
Development

Successfully merging this pull request may close these issues.

CLI cannot create assets due to broken auth check
3 participants
@nhoening @coveralls @Flix6x