Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip units on sensor page #475

Merged
merged 2 commits into from Aug 13, 2022
Merged

Tooltip units on sensor page #475

merged 2 commits into from Aug 13, 2022

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Aug 12, 2022 •
edited

Fix a forgotten update of tooltip units on the sensor page.

This prevents seeing quantities like 500 mMW (milli mega = kilo) for a sensor recording MW units (as happens in the toy tutorial). Instead, we'll now see 0.5 MW.

@Flix6x
Stop using the SI prefix on sensor page (we stopped using it on the a…
32a63c9 
…sset page since c51bd35)

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
changelog entry
7d442fc 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x self-assigned this Aug 12, 2022
@Flix6x Flix6x added this to the 0.11.0 milestone Aug 12, 2022
@Flix6x Flix6x added UI Units Deals with unit conversion labels Aug 12, 2022
@Flix6x Flix6x marked this pull request as ready for review August 12, 2022 11:24
@Flix6x Flix6x requested a review from nhoening August 12, 2022 11:28
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2846396119

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 67.577%
Totals Coverage Status
Change from base Build 2825554854: 0.01%
Covered Lines: 7207
Relevant Lines: 10091
💛 - Coveralls

nhoening
nhoening approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing. I'm out of the loop a bit - can you tell me where I can see the docs for the unit specs?

@Flix6x
Copy link
Contributor Author

Flix6x commented Aug 13, 2022 •
edited

can you tell me where I can see the docs for the unit specs?

https://github.com/d3/d3-format#locale_format

@Flix6x Flix6x merged commit f76abf9 into main Aug 13, 2022
@Flix6x Flix6x deleted the tooltip_units_on_sensor_page branch August 13, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening approved these changes

Assignees

@Flix6x Flix6x

Labels
UI Units Deals with unit conversion
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Flix6x @coveralls @nhoening