Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For Docker standalone tutorial, do not use --net=host #465

Merged
merged 2 commits into from Jul 21, 2022
Merged

For Docker standalone tutorial, do not use --net=host #465

merged 2 commits into from Jul 21, 2022

Conversation

nhoening
Copy link
Contributor

Instead, put the containers in a dedicated docker network. More stable behavior across OSes.

@nhoening
For Docker standalone tutorial, do not use --net=host but instead put…
78d3b04 
… the containers in a dedicated docker network. More stable behaviour across OSes.

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening linked an issue Jul 21, 2022 that may be closed by this pull request
Docker container does not expose UI on port 5000 #464
Closed
@coveralls
Copy link
Collaborator

coveralls commented Jul 21, 2022 •
edited

Pull Request Test Coverage Report for Build 2710846764

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 97 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.06%) to 67.541%
Files with Coverage Reduction New Missed Lines %
flexmeasures/api/v3_0/assets.py 3 96.47%
flexmeasures/ui/views/new_dashboard.py 3 90.0%
flexmeasures/ui/init.py 4 94.12%
flexmeasures/data/services/asset_grouping.py 11 77.0%
flexmeasures/data/queries/utils.py 16 62.5%
flexmeasures/ui/crud/assets.py 28 75.0%
flexmeasures/ui/utils/view_utils.py 32 72.17%
Totals Coverage Status
Change from base Build 2679559260: 0.06%
Covered Lines: 7179
Relevant Lines: 10057
💛 - Coveralls

@nhoening
add changelog entry and link the docker-compose tutorial in the toy t…
4d1c8aa 
…utorial

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening requested a review from Flix6x July 21, 2022 09:48
Flix6x
Flix6x approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be backported to 0.10.x? If so, please move the changelog entry to 10.1.

@nhoening
Copy link
Contributor Author

I don't think it needs to.

@nhoening nhoening merged commit 9d62a1c into main Jul 21, 2022
@nhoening nhoening deleted the 464-docker-container-does-not-expose-ui-on-port-5000 branch July 21, 2022 12:02
@Flix6x Flix6x added this to the 0.11.0 milestone Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flix6x Flix6x Flix6x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

Docker container does not expose UI on port 5000
3 participants
@nhoening @coveralls @Flix6x