Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styling user pages #448

Merged
merged 41 commits into from Jul 8, 2022
Merged

Styling user pages #448

merged 41 commits into from Jul 8, 2022

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Jun 23, 2022

This PR streamlines the styling of user pages and action buttons.

Flix6x added 30 commits June 23, 2022 16:19
@Flix6x
Show updated sensor data and annotations together
76499dc 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Show spinner while fetching new data
51aff4e 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Switch from id-based styling to class-based styling
bf6c5c7 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Move styling to css, and lower spinner
9fd91f1 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Simplify and streamline datepicker fontsize
546cb65 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Streamline datepicker margins
39e3cef 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Add margins and side panel activated on hover
4dae1a0 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Correct margins and padding of side panel to allow for custom ranges …
f64b6e5 
…at the bottom of the calendar

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Show single month
cf13a78 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Fewer custom ranges
6939384 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Side panel rounded similar to buttons rather than similar to cards
8fb6406 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Align box shadows of cards and calendar
1ccfcc9 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Non-transparent cards
37521cc 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Simplified padding notation
48e36e9 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Move chart actions buttons away from the card's corner (negative margin)
5d3db6e 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Rotate y-axis labels to improve legibility
6384e24 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Remove sensor chart title if the same information is already containe…
c6478e1 
…d in the y-axis label

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Move unit to right side of tooltip
97b2bc9 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Style predefined datetime ranges
c8e5dd5 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Raise column to top without requiring flex display
a12acf6 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Rename sidepanel class and separate styling specific to the sidepanel…
2208986 
… being on the left

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Show spinner only while the promise is being fulfilled
50fb0d5 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Cancel previous request when the user makes a new request
ff62e43 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Do not let spinner block the full page height, so the sensor table na…
2c9c0ad 
…vigation can still be used

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Change header and label colors inside the sidepanel to contrast again…
e266ba9 
…st the sidepanel background

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Style navbar logo to have a consistent height and adjust the width of…
fb3d9e0 
… the navbar-header accordingly

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Actually load intended font
20726b2 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Enforce separation of time axis labels
e650208 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Add return type annotation and docs: applying chart defaults returns …
0fe334e 
…a dictionary with vega-lite specs

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Resolve hover glitch when exiting either the list of months or the li…
b25d23d 
…st of years with the pointer. This stops the side panel from collapsing and reopening.

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Enable swiping for left sidepanel
1370f86 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Stop using redundant litepicker plugin, which was messing with calend…
9d8d627 
…ar styling

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Fix test
d21cf3f 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Changelog entry
a6c1c9b 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Synchronize styling of user pages
241ef02 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Style header action buttons
7aaef2b 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added the UI label Jun 23, 2022
@Flix6x Flix6x self-assigned this Jun 23, 2022
@Flix6x Flix6x added this to the 0.11.0 milestone Jun 23, 2022
@Flix6x
Fix test
be45711 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x marked this pull request as ready for review June 23, 2022 15:24
@Flix6x Flix6x requested a review from nhoening June 23, 2022 15:24
@coveralls
Copy link
Collaborator

coveralls commented Jun 23, 2022 •
edited

Pull Request Test Coverage Report for Build 2637723069

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.369%
Totals Coverage Status
Change from base Build 2637707449: 0.0%
Covered Lines: 7096
Relevant Lines: 9844
💛 - Coveralls

Base automatically changed from sensor-chart-ux-improvements to main June 25, 2022 12:05
@Flix6x
Set minimum sidepanel height
7f91114 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Merge remote-tracking branch 'origin/main' into styling-user-pages
9ea248c 
# Conflicts:
#	documentation/changelog.rst
@Flix6x Flix6x merged commit dc554a1 into main Jul 8, 2022
@Flix6x Flix6x deleted the styling-user-pages branch July 8, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening approved these changes

Assignees

@Flix6x Flix6x

Labels
UI
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Flix6x @coveralls @nhoening