Fix UI regressions from 0.10.0 #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Merged
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…them inconsistently across pages) Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
nhoening
approved these changes
Jun 15, 2022
| @@ -177,8 +214,8 @@ p.error { | |||
| } | |||
|
|
|||
| .navbar-default .navbar-nav>li>a { | |||
| color: var(--white); | |||
| font: 500 14px/14px 'Poppins'; | |||
There was a problem hiding this comment.
So we are not using this font at all anymore? Why still import it, then?
I also didn't quite understand why removing a font is best described with "Get rid of serifs".
There was a problem hiding this comment.
It's still imported and used here:
body *:not(.fa, .glyphicon) {
font-family: 'Poppins', sans-serif;
}
So basically for almost any text in the html body. The navbar is part of that body, so there was no need to override the font with a serif version of the same font.
Signed-off-by: F.N. Claessen <felix@seita.nl>
Flix6x
added a commit
that referenced
this pull request
Jun 16, 2022
Fix some UI styling regressions in e.g. color contrast and hover effects. * Remove redundant col divs Signed-off-by: F.N. Claessen <felix@seita.nl> * Add green hover effect to match red hover effect Signed-off-by: F.N. Claessen <felix@seita.nl> * Improve contrast against secondary color Signed-off-by: F.N. Claessen <felix@seita.nl> * Get rid of serifs in menu Signed-off-by: F.N. Claessen <felix@seita.nl> * Improve contrast against secondary color Signed-off-by: F.N. Claessen <felix@seita.nl> * Use secondary color for currently selected data table page Signed-off-by: F.N. Claessen <felix@seita.nl> * Use secondary hover color on hover Signed-off-by: F.N. Claessen <felix@seita.nl> * Split css lines to clarify Signed-off-by: F.N. Claessen <felix@seita.nl> * Synchronize css of navigation components Signed-off-by: F.N. Claessen <felix@seita.nl> * Synchronize css of creation/deletion buttons Signed-off-by: F.N. Claessen <felix@seita.nl> * Synchronize css of other buttons Signed-off-by: F.N. Claessen <felix@seita.nl> * Synchronize css ordering Signed-off-by: F.N. Claessen <felix@seita.nl> * Better contrast in timezone warning Signed-off-by: F.N. Claessen <felix@seita.nl> * Fix alt descriptions in header and footer Signed-off-by: F.N. Claessen <felix@seita.nl> * Synchronize styling of page titles and user action buttons Signed-off-by: F.N. Claessen <felix@seita.nl> * Headers 1, 2 and 3 get the same font size for now (we had been using them inconsistently across pages) Signed-off-by: F.N. Claessen <felix@seita.nl> * Synchronize litepicker styling Signed-off-by: F.N. Claessen <felix@seita.nl> * Changelog entry under 0.10.1 Signed-off-by: F.N. Claessen <felix@seita.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some of the UI regressions and/or unaddressed review comments from the 0.10.0 release.