Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade pint==0.19.1 #415

Merged
merged 8 commits into from Apr 9, 2022
Merged

Upgrade pint==0.19.1 #415

merged 8 commits into from Apr 9, 2022

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Apr 8, 2022 •
edited

Upgrade pint, which now uses h to denote hours instead of Planck's constant (making my workaround redundant). Also prefer shorter units as a general rule.

@Flix6x
Upgrade pint to 0.19 in which h is the symbol for hour rather than Pl…
19f29a8 
…anck's constant

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Simplify setup of unit registry
2f228ef 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Add currencies to list of preferred units
4517b77 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Always prefer shorter units
e47a102 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Add todo to take into account magnitude when deciding what the shorte…
e5efec2 
…st unit is (requires decimal registry)

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Add todo to switch to decimal unit registry
4635d8e 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added the Units Deals with unit conversion label Apr 8, 2022
@Flix6x Flix6x added this to the 0.10.0 milestone Apr 8, 2022
@Flix6x Flix6x self-assigned this Apr 8, 2022
@Flix6x Flix6x requested a review from nhoening April 8, 2022 19:26
@coveralls
Copy link
Collaborator

coveralls commented Apr 8, 2022 •
edited

Pull Request Test Coverage Report for Build 2140129325

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 68.563%
Totals Coverage Status
Change from base Build 2096795314: 0.01%
Covered Lines: 7034
Relevant Lines: 9732
💛 - Coveralls

nhoening
nhoening approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see it became simpler. I get that this library is really helpful for us, but after I haven't worked with it or read about it, I lose the frame of mind. Could we get a quick summary in utils/unit_utils.py how we are using it?

@Flix6x
Add module docstring
76e9dfd 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Changelog entry
27af127 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x merged commit 559eccd into main Apr 9, 2022
@Flix6x Flix6x deleted the upgrade-pint==0.19.1 branch April 9, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening approved these changes

Assignees

@Flix6x Flix6x

Labels
Units Deals with unit conversion
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Flix6x @coveralls @nhoening