Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default chart legibility #413

Merged
merged 10 commits into from Apr 5, 2022
Merged

Default chart legibility #413

merged 10 commits into from Apr 5, 2022

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Apr 5, 2022

I saw some people having trouble reading our chart axes in meetings, so I increased the default font size a bit. Also for our calendar widget.

Some of this code should be useful for chart specs defined in plugins, too.

@Flix6x
Increase default font size in charts
fd5e939 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Create util function for merging chart specs
7ae0a52 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Refactor legibility defaults
b077a7b 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Switch parent and child
d90f30a 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Generalize how string fields are updated with dicts
58c1f51 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Switch one month at a time in the calendar
7e07588 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Increase calendar font size
9ee021d 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Support string field updating for both parent and child dicts
9a9d495 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added the UI label Apr 5, 2022
@Flix6x Flix6x self-assigned this Apr 5, 2022
@coveralls
Copy link
Collaborator

coveralls commented Apr 5, 2022 •
edited

Pull Request Test Coverage Report for Build 2095816652

  • 17 of 19 (89.47%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 68.549%
Changes Missing Coverage Covered Lines Changed/Added Lines %
flexmeasures/data/models/charts/defaults.py 17 19 89.47%
Totals Coverage Status
Change from base Build 2095533104: 0.06%
Covered Lines: 7035
Relevant Lines: 9733
💛 - Coveralls

@Flix6x
Changelog entry
af47f75 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Add test for util function
421a454 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x requested a review from nhoening April 5, 2022 11:28
@Flix6x Flix6x added this to the 0.10.0 milestone Apr 5, 2022
@Flix6x Flix6x merged commit 448938f into main Apr 5, 2022
@Flix6x Flix6x deleted the default-chart-legibility branch April 5, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening approved these changes

Assignees

@Flix6x Flix6x

Labels
UI
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Flix6x @coveralls @nhoening