Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer conversion to short stock units #412

Merged
merged 4 commits into from Apr 5, 2022

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Apr 4, 2022

Catch another case of converting flow units to sensible stock units: t/h to t (tonne) instead of to Mg.

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added the Units Deals with unit conversion label Apr 4, 2022
@Flix6x Flix6x requested a review from nhoening April 4, 2022 15:14
@Flix6x Flix6x self-assigned this Apr 4, 2022
Signed-off-by: F.N. Claessen <felix@seita.nl>
@coveralls
Copy link
Collaborator

coveralls commented Apr 4, 2022

Pull Request Test Coverage Report for Build 2094722255

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 68.49%

Totals Coverage Status
Change from base Build 2071520651: 0.01%
Covered Lines: 7018
Relevant Lines: 9714

💛 - Coveralls

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added this to the 0.9.2 milestone Apr 5, 2022
@Flix6x Flix6x merged commit e58f30e into main Apr 5, 2022
@Flix6x Flix6x deleted the prefer-conversion-to-short-stock-units branch April 5, 2022 11:28
Flix6x added a commit that referenced this pull request Apr 5, 2022
Catch another case of converting flow units to sensible stock units: t/h to t (tonne) instead of to Mg.

* Add test case

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Return shortest unit of stock

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Sneak in some type annotation fixes

Signed-off-by: F.N. Claessen <felix@seita.nl>

* Changelog entry

Signed-off-by: F.N. Claessen <felix@seita.nl>
Flix6x added a commit that referenced this pull request Apr 5, 2022
Signed-off-by: F.N. Claessen <felix@seita.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Units Deals with unit conversion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants