Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In is_running(), list CLI commands generically #411

Merged
merged 2 commits into from Apr 4, 2022

Conversation

nhoening
Copy link
Contributor

@nhoening nhoening commented Apr 3, 2022

Aside from being a solution which would not fail when we add another CLI command, it also allows commands from loaded plugins to be recognized. We need this especially for allowing CLI to do things outside of one account only.

…s from loaded plugins to do things outside of one account only

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening requested a review from Flix6x April 3, 2022 20:40
@coveralls
Copy link
Collaborator

coveralls commented Apr 3, 2022

Pull Request Test Coverage Report for Build 2090344315

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 68.49%

Totals Coverage Status
Change from base Build 2071520651: 0.01%
Covered Lines: 7018
Relevant Lines: 9714

💛 - Coveralls

Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice generalisation!

@Flix6x
Copy link
Contributor

Flix6x commented Apr 4, 2022

Adding a test would be good, actually.

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening requested a review from Flix6x April 4, 2022 14:07
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nhoening nhoening merged commit be0bace into main Apr 4, 2022
@nhoening nhoening deleted the allow-plugin-CLI-commands-access branch April 4, 2022 15:34
@Flix6x Flix6x added this to the 0.9.3 milestone Apr 15, 2022
Flix6x pushed a commit that referenced this pull request Apr 15, 2022
* In is_running(), list CLI commands generically, also allowing commands from loaded plugins to do things outside of one account only

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* add a test for new util function cli.is_running

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants