New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mask locations of inaccessible assets on map #409
Conversation
Signed-off-by: F.N. Claessen <felix@seita.nl>
Pull Request Test Coverage Report for Build 2071349103
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not implement various maskX functions in various places.
We have flexmeasures.data.queries.utils.potentially_limit_query_to_account_assets
, which is supposed to be used here by get_asset_group_queries
(or actually by the query functions it is using).
So this PR is about figuring out why that is not happening.
I don't see how #200 could help here. I also believe we don't need that issue anymore. Our auth policy is pretty powerful, and the |
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
I noticed we were using |
Well, I broke a few tests, so I'll look into that tomorrow. |
… a tuple) Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
…they run via the CLI, so their querying is not hampered Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@Flix6x I can't set you as reviewer for this PR, so I request one this way :) |
And I also can't file an approval for my own PR, so I approve it this way :) Thanks for jumping on the opportunity to improve our auth! |
Does this require a changelog entry? |
Working on it. |
Signed-off-by: F.N. Claessen <felix@seita.nl>
Fix auth bug not masking locations of inaccessible assets on map. * Mask inaccessible assets (workaround for issue #200) Signed-off-by: F.N. Claessen <felix@seita.nl> * fix limiting query to current account Signed-off-by: Nicolas Höning <nicolas@seita.nl> * fix checking for ResponseTuples in API code (type() will say they are a tuple) Signed-off-by: Nicolas Höning <nicolas@seita.nl> * fix querying for null values Signed-off-by: Nicolas Höning <nicolas@seita.nl> * introduce a way for tests that test backend functionality to pretend they run via the CLI, so their querying is not hampered Signed-off-by: Nicolas Höning <nicolas@seita.nl> * Changelog entry Signed-off-by: F.N. Claessen <felix@seita.nl> Co-authored-by: Nicolas Höning <nicolas@seita.nl> Signed-off-by: F.N. Claessen <felix@seita.nl>
Workaround for #200.