Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade timely-beliefs dependency #406

Merged
merged 1 commit into from Mar 29, 2022
Merged

Upgrade timely-beliefs dependency #406

merged 1 commit into from Mar 29, 2022

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Mar 27, 2022

Upgrading timely-beliefs fixes a problem that can occur with resampling, when an event resolution of "H" should be interpreted as "1H" but isn't. This was fixed in SeitaBV/timely-beliefs#100.

ValueError: Could not parse timedelta H, because unit abbreviation w/o a number

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added bug Something isn't working Still Needs Manual Backport labels Mar 27, 2022
@Flix6x Flix6x requested a review from nhoening March 27, 2022 22:16
@Flix6x Flix6x self-assigned this Mar 27, 2022
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2049139457

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.466%

Totals Coverage Status
Change from base Build 2042673022: 0.0%
Covered Lines: 6998
Relevant Lines: 9690

💛 - Coveralls

@Flix6x Flix6x merged commit a7d74c0 into main Mar 29, 2022
@Flix6x Flix6x deleted the upgrade_timely-beliefs branch March 29, 2022 17:33
Flix6x added a commit that referenced this pull request Mar 30, 2022
…ccur with resampling, when an event resolution of "H" should be interpreted as "1H" but isn't. This was fixed in SeitaBV/timely-beliefs#100.

Upgrade timely-beliefs dependency (#406)

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added this to the 0.9.1 milestone Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants