New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move /api/dev/asset to /api/v3_0 #392
Conversation
nhoening
commented
Mar 18, 2022
- move dev asset to v3
- make sure asset CRUD still works
- small improvements to viewing & deleting asset in UI
Pull Request Test Coverage Report for Build 2021914612
💛 - Coveralls |
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
…ng deleted (asset gets also deleted) Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
… additions Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
…sor tests landed) Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
27e60c0
to
6a93b5a
Compare
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean PR. I have some small change requests. If you agree to my suggestions, it might be most efficient to just tell me to implement them. Because I experimented locally on my own suggestions, I have most of theses changes stashed already.
flexmeasures/data/migrations/versions/30f7b63069e1_delete_asset_if_sensor_is_deleted.py
Show resolved
Hide resolved
Thanks! I made a few comments, but in general I'm very fine for you to implement your suggestions. |
Signed-off-by: F.N. Claessen <felix@seita.nl>
… from patching Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Thanks! Do you need me to do anything? E.g. approve? Tell me if you're happy and I'll merge. |
I'm happy. |