Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: flexmeasures show beliefs #379

Merged
merged 25 commits into from Mar 8, 2022
Merged

CLI: flexmeasures show beliefs #379

merged 25 commits into from Mar 8, 2022

Conversation

nhoening
Copy link
Contributor

Simple in-terminal plotting of time series (beliefs). Handy on a server, in development, but certainly handy for tutorials.

@nhoening
first version of flexmeasures show beliefs
2dc13e6 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
add types lib for mypy
5d02ed5 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
construct title at the end when we have all info updated
25a4721 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
update changelogs
01ac3de 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening added this to In progress in Edcuational toy tutorial Feb 28, 2022
@coveralls
Copy link
Collaborator

coveralls commented Feb 28, 2022 •
edited

Pull Request Test Coverage Report for Build 1952341619

  • 47 of 87 (54.02%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 68.581%
Changes Missing Coverage Covered Lines Changed/Added Lines %
flexmeasures/conftest.py 9 11 81.82%
flexmeasures/data/schemas/generic_assets.py 1 3 33.33%
flexmeasures/utils/config_utils.py 0 2 0.0%
flexmeasures/data/schemas/sources.py 8 13 61.54%
flexmeasures/data/schemas/account.py 8 14 57.14%
flexmeasures/cli/data_show.py 21 44 47.73%
Files with Coverage Reduction New Missed Lines %
flexmeasures/data/schemas/generic_assets.py 1 79.17%
Totals Coverage Status
Change from base Build 1946227499: -0.1%
Covered Lines: 6794
Relevant Lines: 9399
💛 - Coveralls

@nhoening nhoening changed the title first version of flexmeasures show beliefs CLI: flexmeasures show beliefs Feb 28, 2022
@nhoening
Merge branch 'main' into cli-show-beliefs
22f1412
@nhoening
add -belief-time-before option
482919f 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
add simple tests for all show data commands
833d4a4 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
flexmeasures/conftest.py
01e5c50 
fix typo in ficture name

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening requested a review from Flix6x February 28, 2022 22:55
@nhoening
verifying that CLI tests do not run on GithubActions
1ab9605 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
move back to ignoring CLI commands on Github Actions
3b8fa00 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
small doc improvement
fd15bb0 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
Copy link
Contributor Author

nhoening commented Mar 1, 2022

A thought (probably a new ticket): This task might be useful to export data to CSV files, as well. That might be useful, especially in the simulation use case.

I'd add a parameter called "--as-csv-file" for the filename. The command could then, in addition to displaying the data, generate the file.

Flix6x
Flix6x requested changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly, I'd like us to use our marshmallow validators more often. I also found some potential problems for more complex cases (i.e. multi-sourced data, probabilistic data and heterogeneous event resolutions), for which I propose straightforward solutions.

flexmeasures/cli/data_show.py Outdated Show resolved Hide resolved
flexmeasures/cli/data_show.py Show resolved Hide resolved
documentation/changelog.rst Outdated Show resolved Hide resolved
flexmeasures/conftest.py Outdated Show resolved Hide resolved
flexmeasures/cli/data_show.py Outdated Show resolved Hide resolved
flexmeasures/cli/data_show.py Outdated Show resolved Hide resolved
flexmeasures/cli/data_show.py Show resolved Hide resolved
flexmeasures/cli/data_show.py Show resolved Hide resolved
flexmeasures/cli/data_show.py Outdated Show resolved Hide resolved
flexmeasures/cli/data_show.py Outdated Show resolved Hide resolved
@nhoening
Merge branch 'main' into cli-show-beliefs
c1a0188
@nhoening
better handling of DEBUG var
94c5bec 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
improve docstring of two fixtures
a57971f 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
if sensor share the same unit, still show it on the y-axis ; Also int…
7c4d4b2 
…roduce Schema for DataSourceIdField

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
Use AwareDateTimeField for --start
cedd21f 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
also use schemas for --duration and --belief-time
47d8b6a 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
use SensorIdField schema for --sensor-id
2d46d47 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
use schemas in show commands for account and asset
63f54a9 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
simplify possible traces we need to show with one_deterministic_belie…
ccdcae1 
…f_per_event=True

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
use source.description in title
1e1f82c 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Flix6x
Flix6x approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that cleans it up nicely. I trust you on fixing the docstrings.

flexmeasures/data/schemas/account.py Outdated Show resolved Hide resolved
flexmeasures/data/schemas/account.py Outdated Show resolved Hide resolved
flexmeasures/data/schemas/account.py Outdated Show resolved Hide resolved
flexmeasures/data/schemas/account.py Outdated Show resolved Hide resolved
flexmeasures/data/schemas/generic_assets.py Outdated Show resolved Hide resolved
flexmeasures/data/schemas/sensors.py Outdated Show resolved Hide resolved
flexmeasures/utils/config_utils.py Show resolved Hide resolved
flexmeasures/data/schemas/sources.py Outdated Show resolved Hide resolved
flexmeasures/cli/data_show.py Outdated Show resolved Hide resolved
flexmeasures/cli/data_show.py Show resolved Hide resolved
@nhoening
improve in-code documentation
c26f6ee 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
resample data from different sensors to minimal resolution if possibl…
49f0150 
…e; be more informative if no data found for a sensor

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
simpler way of making sure data is resample to minimal resolution
84d0926 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening mentioned this pull request Mar 8, 2022
Closed
@nhoening nhoening merged commit 8fe7e8b into main Mar 8, 2022
@nhoening nhoening deleted the cli-show-beliefs branch March 8, 2022 15:54
@nhoening nhoening moved this from In progress to Done in Edcuational toy tutorial Mar 18, 2022
@Flix6x Flix6x added this to the 0.9.0 milestone Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flix6x Flix6x Flix6x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Edcuational toy tutorial
  
Done
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nhoening @coveralls @Flix6x