Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caching to CI test pipeline #361

Merged
merged 12 commits into from Apr 15, 2022
Merged

Add caching to CI test pipeline #361

merged 12 commits into from Apr 15, 2022

Conversation

nhoening
Copy link
Contributor

@nhoening nhoening commented Feb 8, 2022

Caching the Python environment, including installed dependencies. Using tips from https://blog.allenai.org/python-caching-in-github-actions-e9452698e98d

I believe it saves up to 90 seconds per run.

(Installing postgres and cbc takes 45 sec, and running tests 3 minutes)

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening changed the title add-key-with-cache-secret-to-test-task Add caching to CI test pipeline Feb 9, 2022
@coveralls
Copy link
Collaborator

coveralls commented Apr 14, 2022

Pull Request Test Coverage Report for Build 2173458091

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.563%

Totals Coverage Status
Change from base Build 2143298525: 0.0%
Covered Lines: 7034
Relevant Lines: 9732

💛 - Coveralls

…pt, to make it only about postgres installation

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening requested a review from Flix6x April 14, 2022 21:20
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice result. Worth a changelog entry under infrastructure.

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening merged commit 9207b15 into main Apr 15, 2022
@nhoening nhoening deleted the add-cache-secret-to-ci branch April 15, 2022 16:48
@@ -38,7 +38,8 @@ jobs:
id: cache
with:
path: ${{ env.pythonLocation }}
key: ${{ runner.os }}-pip-${{ env.pythonLocation }}-${{ hashFiles('**/requirements/**.txt') }}
# manually disable a cache if needed by (re)setting CACHE_DATE
key: ${{ runner.os }}-pip-${{ env.pythonLocation }}-${{ SECRETS.CACHE_DATE }}-${{ hashFiles('**/requirements/**.txt') }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants