Cli resample sensor #360
Merged
Cli resample sensor #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: F.N. Claessen <felix@seita.nl>
…accordingly Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
nhoening
requested changes
Feb 9, 2022
There was a problem hiding this comment.
Looks good to me.
We now know how to test CLI tasks, so I wonder if we can add a small test. Is there some sample series in some conftest we can resample?
Also: This resamples all data of the sensor. Which is fine. But I have a question about this in practice: I can imagine that new data with a different resolution already started coming in.
- Will our APIs catch that problem at the moment?
- Will this task still be able to resample in the case that data with a different resolution made it in?
# Conflicts: # documentation/changelog.rst
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
This reverts commit bd8f1fa.
Signed-off-by: F.N. Claessen <felix@seita.nl>
|
Great suggestion! The CLI command now let's you pass a time window. |
nhoening
approved these changes
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a CLI command to resample sensor data to a different resolution.
Requires SeitaBV/timely-beliefs#99.