Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 350 plugins can import most commonly used flex measures classes from a central place #354

Merged
merged 4 commits into from Feb 4, 2022
Merged

Issue 350 plugins can import most commonly used flex measures classes from a central place #354

merged 4 commits into from Feb 4, 2022

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Feb 3, 2022

Closes #350.

@Flix6x
Let common classes be imported from a central place in flexmeasures
03058c5 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Add test
a8f4ac6 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x requested a review from nhoening February 3, 2022 11:17
@Flix6x Flix6x self-assigned this Feb 3, 2022
@Flix6x
Changelog entry
7d93326 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Copy link
Contributor Author

Flix6x commented Feb 3, 2022 •
edited

Should we add the following, too?

  • Role
  • Annotation
  • GenericAssetType as AssetType
  • TimedBelief (not sure about this one, because we'd prefer plugins to use timely_beliefs.BeliefsDataFrame in combination with flexmeasures.data.save_to_db)

I guess it doesn't make sense to add any classes mapped to m-n tables, nor the LatestTaskRun class.

@nhoening
Copy link
Contributor

nhoening commented Feb 3, 2022

I'd add Annotation and AssetType.

@Flix6x
Consider Annotation and GenericAssetType as common classes, too
a28acca 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Copy link
Contributor Author

Flix6x commented Feb 3, 2022

👍

@Flix6x Flix6x merged commit 6e9e62b into main Feb 4, 2022
@Flix6x Flix6x deleted the Issue-350_Plugins_can_import_most_commonly_used_FlexMeasures_classes_from_a_central_place branch February 4, 2022 13:33
@Flix6x Flix6x added this to the 0.9.0 milestone Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening approved these changes

Assignees

@Flix6x Flix6x

Labels
Plugin support
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

Plugins can import most commonly used FlexMeasures classes from a central place
2 participants
@Flix6x @nhoening