Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLI command to delete unchanged beliefs #328

Merged
merged 17 commits into from Jan 26, 2022
Merged

Add CLI command to delete unchanged beliefs #328

merged 17 commits into from Jan 26, 2022

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Jan 20, 2022 •
edited

Closes #327

Requires SeitaBV/timely-beliefs#96.

The 3 new CLI commands that this PR introduces can be found under flexmeasures delete --help.

@Flix6x
Add CLI command to delete unchanged beliefs
9e4188f 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x self-assigned this Jan 20, 2022
@Flix6x
.count() instead of .all() to get to prompt faster
e610be9 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Set batch size outside of loop
721985b 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Shorter statements to confirm prompts
bd7633f 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Allow excluding forecasts or measurements when deleting unchanged bel…
8617e8a 
…iefs

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Clearer CLI option names, and use new tb method options
690b582 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x marked this pull request as ready for review January 24, 2022 10:17
@Flix6x Flix6x requested a review from nhoening January 24, 2022 10:17
nhoening
nhoening requested changes Jan 24, 2022
View reviewed changes
flexmeasures/cli/data_delete.py Outdated Show resolved Hide resolved
flexmeasures/cli/data_delete.py Outdated Show resolved Hide resolved
@Flix6x
Add command to delete NaN values
fd6d5ec 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added this to the 0.9.0 milestone Jan 24, 2022
@Flix6x
Streamline CLI option defaults
d0a39cc 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Merge remote-tracking branch 'origin/main' into Issue-327_CLI_command…
7b8eddf 
…_to_clean_database_by_removing_unchanged_beliefs
@Flix6x
Clarify prompt
704cf3b 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Bump timely-beliefs dependency
18c5622 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Add command to delete a sensor along with its data
0913a27 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x requested a review from nhoening January 26, 2022 18:52
nhoening
nhoening approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

I'm working on a PR which moves dev-add commands into the official group.

I believe these commands can also be official right away? Or at least add sensor ...

@Flix6x
Copy link
Contributor Author

Flix6x commented Jan 26, 2022

Okay. I had only made delete sensor "official" right away, but I'll add the others then, too.

@Flix6x
Move commands to "official" CLI delete group, and get rid of the dev-…
d5a30b7 
…delete group

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
sensor_id is required for delete_sensor
118f15c 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Add option to delete NaN values for a single sensor only
45613a5 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Merge branch 'main' into Issue-327_CLI_command_to_clean_database_by_r…
a5e92bc 
…emoving_unchanged_beliefs
@Flix6x
Changelog entry
ea18545 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x merged commit 1c7c760 into main Jan 26, 2022
@Flix6x Flix6x deleted the Issue-327_CLI_command_to_clean_database_by_removing_unchanged_beliefs branch January 26, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening approved these changes

Assignees

@Flix6x Flix6x

Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

CLI command to clean database by removing unchanged beliefs
2 participants
@Flix6x @nhoening