Deprecate portfolio and analytics views #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Flix6x
moved this from In progress
to Review in progress
in Support Sensor and Asset diversity
nhoening
reviewed
Jan 19, 2022
Maybe just because I'm not emotionally there yet. I didn't set out to throw out code here, just to unlink that which wasn't made compatible at this point with the new data model, and is therefore essentially broken. I guess the links are decent placeholders for placing back links to whatever we end up replacing the analytics view with. And in the views there are some UI tables that could probably be moved rather than deleted, which should result in a more useful git history. |
|
So we can make a ticket to remove them in the deprecation ticket? |
I made a new ticket in project 11. |
nhoening
approved these changes
Jan 19, 2022
Support Sensor and Asset diversity
automation
moved this from Review in progress
to Reviewer approved
Jan 19, 2022
Support Sensor and Asset diversity
automation
moved this from Reviewer approved
to Done
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.