UI: Dashboard using GenericAssets #251
Conversation
![create-issue-branch[bot]](https://avatars.githubusercontent.com/in/36017?s=60&v=4){kind=small}
…hboard_using_GenericAssets
…class AssetGroup, which is aimed to replace resources.Resource; created new view /sensor/<id>/state
|
I feel the introduction we place on the left (" In a world with renewable energy, flexibility ...") could go away. What do you think? |
I agree. One alternative is to move it to an "About" modal in the footer, next to "Credits". After all, this copy did receive quite some attention. |
…ntify power sensors by unit
…tion and power sensors
flexmeasures/utils/unit_utils.py
Outdated
| >>> is_power_unit("°C") # False | ||
| >>> is_power_unit("EUR/kWh") # True | ||
| """ | ||
| return unit in ("W", "Wh", "kW", "kWh", "MW", "MWh") |
There was a problem hiding this comment.
Wh, kWh and MWh are not power units.
There was a problem hiding this comment.
That's true.
Would it not make sense to also include in the dashboard sensors which report energy (e.g. kWh)?
There was a problem hiding this comment.
No. Metering is a big world. If you know about a general rule which lets all sensors send power data exclusively, let me know.
There was a problem hiding this comment.
Would it not make sense to also include in the dashboard sensors which report energy (e.g. kWh)?
Then also, no.
There was a problem hiding this comment.
I can't parse this answer. Does it mean "no"?
flexmeasures/utils/unit_utils.py
Outdated
|
|
||
| def is_power_unit(unit: str) -> bool: | ||
| """For example: | ||
| >>> is_power_unit("kWh") # True |
There was a problem hiding this comment.
Perhaps a good place to start using pint:
def is_power_unit(unit: str) -> bool:
return (pint.Quantity(unit) / pint.Quantity("W")).dimensionless
There was a problem hiding this comment.
I believe that should not be introduced this quickly: From my examples, it can already lead to these kinds of errors:
pint.errors.UndefinedUnitError: 'EUR' is not defined in the unit registry
pint.errors.OffsetUnitCalculusError: Ambiguous operation with offset unit (degree_Celsius, watt).
There was a problem hiding this comment.
Good point. I have been experimenting with pint today, and there are quite a few issues that would still need streamlining. I'd be happy to take this on in a separate PR.
closes #249