Fix get chart #223
Merged
Fix get chart #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I forgot to remove these in PR #168.
|
Can we realistically get this into 0.7.0 which I plan to get out today? We can split the bugfix from the tests. |
|
Splitting the work on the to-be-made test from the present fix is fine for me. |
nhoening
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sensors/<id>/chartview had been broken, which I hadn't picked up on before because:sensors/<id>view, which is nicer because it is interactive (i.e. has a calendar).I also thought about creating
test_sensor_crud.py, but I think it would need mock API responses. You did this previously intest_asset_crud.py, but I find it hard to replicate. Maybe you could help me along?